Fix failing tests

includes/class-convertkit-mm-actions.php

@@ -79,7 +79,7 @@ public function add_member( $member_data ) {
 
 		// Fetch data from member array.
 		$user_email    = $member_data['email'];
-		$first_name    = rawurlencode( $member_data['first_name'] );
+		$first_name    = $member_data['first_name'];
 		$tag_id        = $this->settings->get_membership_level_mapping( $member_data['membership_level'] );
 		$custom_fields = $this->get_custom_fields_data( $member_data );
 
@@ -106,7 +106,7 @@ public function update_member( $member_data ) {
 		// Define new member data.
 		$user_email    = $member_data['email'];
 		$last_email    = ( array_key_exists( 'last_email', $member_data ) ? $member_data['last_email'] : $member_data['email'] );
-		$first_name    = rawurlencode( $member_data['first_name'] );
+		$first_name    = $member_data['first_name'];
 		$custom_fields = $this->get_custom_fields_data( $member_data );
 
 		// Update the subscriber with their new information.
@@ -138,7 +138,7 @@ public function status_change_member( $member_data ) {
 
 		// Fetch data from member array.
 		$user_email    = $member_data['email'];
-		$first_name    = rawurlencode( $member_data['first_name'] );
+		$first_name    = $member_data['first_name'];
 		$tag_id        = $this->settings->get_membership_level_cancellation_mapping( $member_data['membership_level'] );
 		$custom_fields = $this->get_custom_fields_data( $member_data );
 
@@ -176,7 +176,7 @@ public function delete_member( $member_data ) {
 
 		// Fetch data from member array.
 		$user_email    = $member_data['email'];
-		$first_name    = rawurlencode( $member_data['first_name'] );
+		$first_name    = $member_data['first_name'];
 		$tag_id        = $this->settings->get_membership_level_cancellation_mapping( $member_data['membership_level'] );
 		$custom_fields = $this->get_custom_fields_data( $member_data );
 
@@ -210,7 +210,7 @@ public function purchase_product( $purchase_data ) {
 
 		// Fetch data from purchase array.
 		$user_email    = $purchase_data['email'];
-		$first_name    = rawurlencode( $purchase_data['first_name'] );
+		$first_name    = $purchase_data['first_name'];
 		$tag_id        = $this->settings->get_product_mapping( $purchase_data['product_id'] );
 		$custom_fields = $this->get_custom_fields_data( $purchase_data );
 
@@ -237,7 +237,7 @@ public function add_bundle( $purchase_data ) {
 
 		// Fetch data from purchase array.
 		$user_email    = $purchase_data['email'];
-		$first_name    = rawurlencode( $purchase_data['first_name'] );
+		$first_name    = $purchase_data['first_name'];
 		$tag_id        = $this->settings->get_bundle_mapping( $purchase_data['bundle_id'] );
 		$custom_fields = $this->get_custom_fields_data( $purchase_data );
 
@@ -277,7 +277,7 @@ public function status_change_bundle( $member_data ) {
 
 		// Fetch data from member array.
 		$user_email    = $member_data['email'];
-		$first_name    = rawurlencode( $member_data['first_name'] );
+		$first_name    = $member_data['first_name'];
 		$custom_fields = $this->get_custom_fields_data( $member_data );
 
 		// If no tag assigned to this Bundle, bail.

tests/acceptance/member-update/MemberSubscribeCest.php

@@ -66,7 +66,7 @@ public function testMemberNameAndEmailUpdatedWhenChangedInMemberMouse(Acceptance
 		// Check that the subscriber has the custom field data.
 		$I->apiCustomFieldDataIsValid(
 			$I,
-			$subscriber,
+			$subscriberAfterNewEmailAddress,
 			[
 				'last_name' => $newLastName,
 			]