chore: 7th kadai

[ylv-io]

Description

Type of change

• Bug fix
• New feature
• Breaking change
• Dependency changes
• Deployment
• Forge Script
• Code refactor / cleanup
• Documentation or wording changes
• Other

Checklist:

• The diff is legible and has no extraneous changes
• Complex code has been commented, including external interfaces
• Tests have 100% code coverage
• The base branch is either main, or there's a description of how to merge

Issue Resolution

[github-actions]

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

• unchecked-transfer (1 results) (High)

unchecked-transfer

Impact: High
Confidence: Medium

• ID-0
  AaveWithdrawWorkflow.withdraw(address,uint256) ignores return value by IERC20(asset).transfer(safe,fee)

kinto-core/src/access/workflows/AaveWithdrawWorkflow.sol

Lines 50 to 64 in f333838

	function withdraw(address asset, uint256 amount) public returns (uint256) {
	address pool = poolAddressProvider.getPool();
	// If amount is max uint256, withdraw all available
	if (amount == type(uint256).max) {
	amount = IERC20(IAavePool(pool).getReserveData(asset).aTokenAddress).balanceOf(address(this));
	}
	// Withdraw from Aave
	IAavePool(pool).withdraw(asset, amount, address(this));
	// Send the fee to the Safe
	uint256 fee = amount * FEE / 1e18;
	IERC20(asset).transfer(safe, fee);
	return amount - fee;
	}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (9ddbc8c) to head (ee1ee10).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   88.83%   88.83%           
=======================================
  Files          41       41           
  Lines        2579     2579           
=======================================
  Hits         2291     2291           
  Misses        288      288