Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script Multi Send Kinto #331

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Script Multi Send Kinto #331

merged 5 commits into from
Dec 18, 2024

Conversation

ylv-io
Copy link
Collaborator

@ylv-io ylv-io commented Dec 17, 2024

Description

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Deployment
  • Forge Script
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

… to V4, implement multi-send script, update system contracts, and modify test artifacts for chain 7887.
…d batch minting functionality, and replace EngenBadges with BridgedToken.
Copy link

openzeppelin-code bot commented Dec 17, 2024

Script Multi Send Kinto

Generated at commit: c1163f8b2a6d5ee65ea9e858bcc9ac20738ee68c

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
4
2
0
12
39
57
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 88.20%. Comparing base (33807bc) to head (c1163f8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/tokens/bridged/BridgedToken.sol 0.00% 10 Missing ⚠️
src/tokens/bridged/BridgedKinto.sol 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   89.06%   88.20%   -0.86%     
==========================================
  Files          41       41              
  Lines        2488     2502      +14     
==========================================
- Hits         2216     2207       -9     
- Misses        272      295      +23     
Files with missing lines Coverage Δ
src/tokens/bridged/BridgedKinto.sol 80.00% <0.00%> (-15.24%) ⬇️
src/tokens/bridged/BridgedToken.sol 64.28% <0.00%> (-35.72%) ⬇️

... and 1 file with indirect coverage changes

…, fix voting supply, and update BridgedKinto with fixVotingSupply function.
…nd test artifacts for Kinto token upgrade on chain 7887, including new KV5-impl address.
@ylv-io ylv-io merged commit 20d6a0d into main Dec 18, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant