refactor: bytes signature library #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slither reportTHIS CHECKLIST IS NOT COMPLETE. Use
solc-versionImpact: Informational
|
fedealconada
force-pushed
the
refactor-bytes-signature
branch
from
b64d1fa to
9a3d469
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 73.72% 75.87% +2.15%
==========================================
Files 10 9 -1
Lines 411 398 -13
Branches 113 112 -1
==========================================
- Hits 303 302 -1
+ Misses 48 38 -10
+ Partials 60 58 -2
|
rrecuero
reviewed
Jan 7, 2024
| bytes[] memory extracted = ByteSignature.extractSignatures(fullSignature, 2); | ||
| assertEq(extracted[0], signature1, "The first signature does not match the original signature."); | ||
| assertEq(extracted[1], signature2, "The second signature does not match the original signature."); | ||
| } |
There was a problem hiding this comment.
can we add another test with 3 just in case? It should work
There was a problem hiding this comment.
i've added a fuzz test so we test any amount of signatures
|
It is much better generalized this way. I started with one or two and added three and never changed it. 🙏 |
rrecuero
requested changes
Jan 7, 2024
fedealconada
force-pushed
the
refactor-bytes-signature
branch
from
2faaff6 to
01c11fe
Compare
fedealconada
force-pushed
the
refactor-bytes-signature
branch
from
01c11fe to
7048cec
Compare
…support libraries yet
fedealconada
force-pushed
the
refactor-bytes-signature
branch
from
7048cec to
e34c898
Compare
rrecuero
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
BytesSignature.sol. WDYT @rrecuero ?