Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble up errors from UserOperationRevertReason #29

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

fedealconada
Copy link
Contributor

Adds a assertRevertReasonEq helpers that allows us to assert the revert reasons emitted on the UserOperationRevertReason.

fixes #15

@fedealconada fedealconada requested a review from rrecuero January 5, 2024 18:40
Copy link

github-actions bot commented Jan 5, 2024

Changes to gas cost

Generated at commit: d045aea2755bf9509324e2046be051812a5318c4, compared to commit: 50904e5223f7a8218fd8ddc7700664db5b73879b

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
KintoWalletTest createUserOperation
createUserOperationBatchWithPaymaster
+213 ❌
+121 ❌
+1.25%
+0.70%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
KintoWalletTest 36,085,563 (+1,258,728) createUserOperation
createUserOperationBatchWithPaymaster
createUserOperationWithPaymaster
16,026 (+213)
16,102 (+121)
8,253 (+23)
+1.35%
+0.76%
+0.28%
17,276 (+213)
17,352 (+121)
9,749 (+23)
+1.25%
+0.70%
+0.24%
17,276 (+213)
17,352 (+121)
9,659 (+23)
+1.25%
+0.70%
+0.24%
18,526 (+213)
18,602 (+121)
11,706 (+23)
+1.16%
+0.65%
+0.20%
2 (0)
2 (0)
50 (0)
EngenCreditsTest 25,477,155 (+577,897) createUserOperationWithPaymaster 8,208 (+1) +0.01% 8,421 (+1) +0.01% 8,208 (+1) +0.01% 8,705 (+1) +0.01% 7 (0)
KintoWalletFactoryTest 29,304,118 (+609,623) createUserOperationWithPaymaster 8,683 (+1) +0.01% 8,683 (+1) +0.01% 8,683 (+1) +0.01% 8,683 (+1) +0.01% 1 (0)

Copy link

github-actions bot commented Jan 5, 2024

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

solc-version

Impact: Informational
Confidence: High

  • ID-0
    solc-0.8.17 is not recommended for deployment

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50904e5) 73.72% compared to head (271cac0) 73.72%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           test-fail-refactor      #29   +/-   ##
===================================================
  Coverage               73.72%   73.72%           
===================================================
  Files                      10       10           
  Lines                     411      411           
  Branches                  113      113           
===================================================
  Hits                      303      303           
  Misses                     48       48           
  Partials                   60       60           

Copy link
Contributor

@rrecuero rrecuero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@fedealconada fedealconada merged commit 03ee289 into test-fail-refactor Jan 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants