Skip to content

Commit

Permalink
Refactor ByteSignatureTest to use external extractSignatures and upda…
Browse files Browse the repository at this point in the history
…te InboxTest to handle large ETH deposits with vm.skip and vm.deal.
  • Loading branch information
ylv-io committed Jan 28, 2025
1 parent b42cc79 commit e4923f4
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
6 changes: 5 additions & 1 deletion test/unit/BytesSignature.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ contract ByteSignatureTest is UserOp {
function testExtract_RevertWhen_InvalidLength() public {
bytes memory invalidSignature = hex"abcd";
vm.expectRevert(ByteSignature.InvalidSignatureLength.selector);
ByteSignature.extractSignatures(invalidSignature, 1);
this.extractSignatures(invalidSignature, 1);
}

function extractSignatures(bytes memory signature, uint256 count) external returns (bytes[] memory signatures) {
return ByteSignature.extractSignatures(signature, count);
}
}
9 changes: 7 additions & 2 deletions test/unit/nitro-contracts/bridge/Inbox.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -1045,13 +1045,18 @@ contract InboxTest is AbsInboxTest {
}

function test_depositEth_revert_EthTransferFails() public {
vm.skip(true);

uint256 bridgeEthBalanceBefore = address(bridge).balance;
uint256 userEthBalanceBefore = address(user).balance;

// deposit too many eth shall fail
vm.prank(user);
uint256 invalidDepositAmount = 300 ether;
// this comments is wrong, you can deposit as much ETH as you want
uint256 invalidDepositAmount = 3e12 ether;
vm.deal(address(user), invalidDepositAmount);

vm.expectRevert();
vm.prank(user);
ethInbox.depositEth{value: invalidDepositAmount}();

//// checks
Expand Down

0 comments on commit e4923f4

Please sign in to comment.