Remove info::platform::profile from the header #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, DPC++ does seem to implement this, but I'm still in favor of removing it from the spec. I think this is a holdover from OpenCL, which supports the CL_PLATFORM_PROFILE query. |
gmlueck
approved these changes
Aug 26, 2024
TApplencourt
approved these changes
Aug 26, 2024
|
CI failure is due to new the "PR to CTS" thingy step |
|
@psalz could you please have a look at the CI failure? |
Edit: Nevermind, I believe it's because you're not a member of the @KhronosGroup organization, the job failed to assign the issue to you. I will look into that! |
tomdeakin
approved these changes
Aug 28, 2024
|
Waiting on CTS fix. |
|
The CTS fix has been implemented and merged. This can now also be merged. |
|
Wg approved to merge. |
gmlueck
pushed a commit
to gmlueck/SYCL-Docs
that referenced
this pull request
Sep 26, 2024
Cherry pick KhronosGroup#608 from main (cherry picked from commit 88f0d48)
gmlueck
pushed a commit
that referenced
this pull request
Nov 7, 2024
Remove info::platform::profile from the header (cherry picked from commit 88f0d48)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is never described in the spec.
Alternatively, we could bring the description in the spec back and mark it deprecated.