Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hostTaskSynopsis.h #527

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Update hostTaskSynopsis.h #527

merged 4 commits into from
Jan 11, 2024

Conversation

mkinsner
Copy link

@mkinsner mkinsner commented Jan 3, 2024

Editorial fix

@mkinsner mkinsner mentioned this pull request Jan 3, 2024
Merged
@TApplencourt
Copy link
Contributor

I guess when we run clang_format, it was confused by the ... and messed it up

@gmlueck gmlueck added the editorial Some purely editorial problem label Jan 3, 2024
Mike Kinsner and others added 3 commits January 4, 2024 12:59
@tomdeakin
Update adoc/headers/hostTask/hostTaskSynopsis.h
3f08b47 
Co-authored-by: Tom Deakin <[email protected]>
@tomdeakin
Update adoc/headers/hostTask/hostTaskSynopsis.h
cfdc833 
Co-authored-by: Tom Deakin <[email protected]>
@gmlueck
Some more related tweaks
958d6ad 
* Update "classHandler/hostTask.h", which has the same problem.
* Fix the indentation to match the other synopses.
@gmlueck
Copy link
Contributor

gmlueck commented Jan 4, 2024

@mkinsner: I noticed that there was a second code snippet that had exactly the same problem just a couple pages later in the spec. I fixed this and also changed the indentation in 958d6ad. If you agree with that update, please give this comment a thumbs-up. I'll wait for that before merging.

keryell
keryell approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@gmlueck gmlueck merged commit a8c24ff into SYCL-2020/master Jan 11, 2024
3 checks passed
keryell pushed a commit that referenced this pull request Sep 10, 2024
@gmlueck
Merge pull request #527 from KhronosGroup/mkinsner-hosttasksynop
d91b975 
Update hostTaskSynopsis.h
gmlueck added a commit that referenced this pull request Nov 7, 2024
@gmlueck
Merge pull request #527 from KhronosGroup/mkinsner-hosttasksynop
a93b3cd 
Update hostTaskSynopsis.h

(cherry picked from commit a8c24ff)
gmlueck added a commit that referenced this pull request Nov 7, 2024
@gmlueck
Merge pull request #527 from KhronosGroup/mkinsner-hosttasksynop
4401bdb 
Update hostTaskSynopsis.h

(cherry picked from commit a8c24ff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomdeakin tomdeakin tomdeakin left review comments

@TApplencourt TApplencourt TApplencourt approved these changes

@gmlueck gmlueck gmlueck approved these changes

@keryell keryell keryell approved these changes

Assignees
No one assigned
Labels
editorial Some purely editorial problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkinsner @TApplencourt @gmlueck @tomdeakin @keryell