Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify NonSemantic Shader DebugInfo Line/Column #312

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spencer-lunarg
Copy link
Contributor

Every text editor I am aware of use 1-index for line/columns and I would imagine the same for Shader DebugInfo

This adds a section to clarify that a Line/Column of 1 is the start

Copy link
Collaborator

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should match DWARF5 even more closely. From Section 6.2.2 of the DWARF5 specification:

Line: An unsigned integer indicating a source line number. Lines are numbered beginning at 1. The compiler may emit the value 0 in cases where an instruction cannot be attributed to any source line.

Column: An unsigned integer indicating a column number within a source line. Columns are numbered beginning at 1. The value 0 is reserved to indicate that a statement begins at the “left edge” of the line.

@spencer-lunarg
Copy link
Contributor Author

I wonder if we should match DWARF5 even more closely. From Section 6.2.2 of the DWARF5 specification:

Wow, that is WAY better of a description and basically want I wanted to say

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants