Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SpvReflectEntryPoint::output_vertices being stomped by other execution modes #256

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Fix SpvReflectEntryPoint::output_vertices being stomped by other execution modes #256

merged 1 commit into from
Mar 27, 2024

Conversation

handsomematt
Copy link
Contributor

@handsomematt handsomematt commented Mar 27, 2024 •
edited
Loading

These execution modes set and stomp output_vertices with invalid data since they have no extra operands.

[4]  OpExecutionMode %2 OutputVertices 128
[5]  OpExecutionMode %2 Invocations 1
[6]  OpExecutionMode %2 InputPoints

With this SPIRV generated by DXC InputPoints would stomp the OutputVertices value to a non-existent value

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

spencer-lunarg
spencer-lunarg approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@spencer-lunarg spencer-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is clearly a bug, not sure how these Execution Mode got here

@spencer-lunarg spencer-lunarg merged commit c7be9dc into KhronosGroup:main Mar 27, 2024
5 checks passed
@handsomematt handsomematt deleted the fix-output-vertices branch March 27, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-lunarg spencer-lunarg spencer-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@handsomematt @CLAassistant @spencer-lunarg