-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Attention][Feature] Rewrite config #21
base: dev/1.21
Are you sure you want to change the base?
Conversation
Oh my god conflict |
I didn't know why the file i removed but it still conflict hum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my god conflict
All right I fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK now it can merge
Cool |
config/common/src/main/java/band/kessoku/lib/api/config/ConfigBasicCodec.java
Outdated
Show resolved
Hide resolved
config/common/src/main/java/band/kessoku/lib/api/config/api/Config.java
Outdated
Show resolved
Hide resolved
config/common/src/main/java/band/kessoku/lib/api/config/api/Comment.java
Outdated
Show resolved
Hide resolved
config/common/src/main/java/band/kessoku/lib/api/config/api/ConfigData.java
Outdated
Show resolved
Hide resolved
config/common/src/main/java/band/kessoku/lib/api/config/values/IdentifierValue.java
Outdated
Show resolved
Hide resolved
config/common/src/main/java/band/kessoku/lib/api/config/values/MapValue.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice code
Note we are already in band.kessoku.lib.api.config
, don't create another api
package
Also I cannot understand how to use ArrayValue
and MapValue
? Can you write some examples about how to use them since they are different from other config values
# Conflicts: # config/common/src/main/java/band/kessoku/lib/api/config/exception/IllegalValueException.java
Rewrite all config.