Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Breadcrumb 수정 #185

Merged
merged 4 commits into from
Dec 12, 2024
Merged

[FEAT] Breadcrumb 수정 #185

merged 4 commits into from
Dec 12, 2024

Conversation

kimeodml
Copy link
Collaborator

What is this PR? 🔍

Changes 📝

Breadcrumb api의 경우 전체 카테고리 조회 대신 계층 카테고리 조회 api로 기능 구현이 가능해서 변경했습니다.

ScreenShot 📷

Precaution

✔️ Please check if the PR fulfills these requirements

  • It's submitted to the correct branch, not the develop branch unconditionally?
  • If on a hotfix branch, ensure it targets main?
  • There are no warning message when you run npm run lint

@kimeodml kimeodml self-assigned this Dec 12, 2024
haejinyun
haejinyun approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@haejinyun haejinyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~
테스트 과정에서 하나 걸리는게 있어 리뷰 남겼습니다!
인증인가쪽 개발이 추가 되면 문제가 안될 수도 있을 것 같아서 일단 approve하고 인증인가와 함께 봐서 추가 대응 하도록 해요~

@kimeodml kimeodml merged commit c4ff4d4 into develop Dec 12, 2024
2 checks passed
@kimeodml kimeodml deleted the feat/#179 branch December 12, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haejinyun haejinyun haejinyun approved these changes

Assignees

@kimeodml kimeodml

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Breadcrumb 로직 수정
2 participants
@kimeodml @haejinyun