Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 웹 사이트에서 북마크 생성하는 컴포넌트 및 로직 제거. 익스텐션 이동하는 방식으로 변경 #931

Merged
merged 2 commits into from
Jan 8, 2025
Merged

[FEAT] 웹 사이트에서 북마크 생성하는 컴포넌트 및 로직 제거. 익스텐션 이동하는 방식으로 변경 #931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07aacdf
feat: 사용하지 않는 OG Data 호출 함수 삭제
dmdgpdi Jan 8, 2025
3ca3d0e
feat: 북마크 생성 버튼 익스텐션 링크 이동으로 기능 변경
dmdgpdi Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions frontend/techpick/src/apis/apiConstants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const API_ENDPOINTS = {
BASIC: 'basic',
PICKS: 'picks',
TAGS: 'tags',
LINKS: 'links',
SHARED: 'shared',
LOGOUT: 'logout',
VIEW: 'view',
Expand Down Expand Up @@ -48,7 +47,6 @@ export const API_URLS = {
GET_TAGS: `${API_ENDPOINTS.TAGS}`,
GET_PICK_BY_URL: (url: string) =>
`${API_ENDPOINTS.PICKS}/link-v2?link=${url}`,
GET_LINK_OG_DATA: (url: string) => `${API_ENDPOINTS.LINKS}?url=${url}`,
SHARE_FOLDER: API_ENDPOINTS.SHARED,
GET_SHARED_FOLER_BY_UUID: (uuid: string) => `${API_ENDPOINTS.SHARED}/${uuid}`,
DELETE_SHARED_FOLER_BY_FOLDER_ID: (sourceFolderId: number) =>
Expand Down
22 changes: 0 additions & 22 deletions frontend/techpick/src/apis/getLinkOgDataByUrl.ts
View file
Open in desktop

This file was deleted.

17 changes: 17 additions & 0 deletions frontend/techpick/src/components/ChromeExtensionLinkButton/ChromeExtensionLinkButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { PlusIcon } from 'lucide-react';
import { chromeExtensionLinkButtonStyle } from './chromeExtensionLinkButton.css';

export function ChromeExtensionLinkButton() {
return (
<a
href="https://chromewebstore.google.com/detail/%EB%B0%94%EA%B5%AC%EB%8B%88-%EC%9D%B5%EC%8A%A4%ED%85%90%EC%85%98/gfkkgllophliamkdclhekgfiohnbdddl"
target="_blank"
rel="noopener noreferrer"
>
<button className={chromeExtensionLinkButtonStyle}>
<PlusIcon size={12} />
<span>북마크 추가하기</span>
</button>
</a>
);
}
17 changes: 17 additions & 0 deletions frontend/techpick/src/components/ChromeExtensionLinkButton/chromeExtensionLinkButton.css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { style } from '@vanilla-extract/css';
import { orangeOutlineButtonStyle } from '@/styles/orangeButtonStyle.css';

export const chromeExtensionLinkButtonStyle = style([
orangeOutlineButtonStyle,
{
display: 'flex',
flexShrink: 0,
gap: '4px',
justifyContent: 'center',
alignItems: 'center',
width: '112px',
height: '24px',
fontSize: '12px',
cursor: 'pointer',
},
]);
91 changes: 0 additions & 91 deletions frontend/techpick/src/components/CreatePickPopover/CreatePickPopoverButton.tsx
View file
Open in desktop

This file was deleted.

66 changes: 0 additions & 66 deletions frontend/techpick/src/components/CreatePickPopover/createPickPopoverButton.css.ts
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions frontend/techpick/src/components/FolderContentHeader/FolderContentHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
folderContentHeaderStyle,
folderDescriptionStyle,
} from './folderContentHeader.css';
import { CreatePickPopoverButton } from '../CreatePickPopover/CreatePickPopoverButton';
import { ChromeExtensionLinkButton } from '../ChromeExtensionLinkButton/ChromeExtensionLinkButton';

export function FolderContentHeader() {
const pathname = usePathname();
Expand All @@ -33,7 +33,7 @@ export function FolderContentHeader() {

<div className={createPickPopoverButtonLayoutStyle}>
{folderInfo?.folderType !== 'RECYCLE_BIN' && (
<CreatePickPopoverButton />
<ChromeExtensionLinkButton />
)}
</div>
</div>
Expand Down
4 changes: 0 additions & 4 deletions frontend/techpick/src/types/pick.type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,6 @@ export type CreatePickRequestType = ConcreteType<
components['schemas']['baguni.api.application.pick.dto.PickApiRequest$Create']
>;

export type GetOgTagDataResponseType = ConcreteType<
components['schemas']['baguni.api.application.link.dto.LinkApiResponse']
>;

export type CreatePickResponseType = ConcreteType<
components['schemas']['baguni.api.application.pick.dto.PickApiResponse$Pick']
>;
Loading