[FEAT] SPA에서 metadata 가져오기. #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
유튜브에서 meta image 및 title을 가져올 수 있습니다.
Changes 📝
기존에는 dom에 접근해서 html을 parsing해서 meta tag의 정보를 가져왔습니다.
하지만 이 방식으로는 유튜브에서 내부적으로 이동한 뒤에 다른 영상을 볼 때 다른 메타 데이터를 가져오지 않았습니다. (이유는 유튜브에서 meta tag가 변경되지 않기 때문입니다.)
따라서 worker에서 탭이 변경될 때마다, url이 바뀔 때마다 tab의 정보를 가져오는 것으로 로직을 변경했습니다.
Precaution