Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PBESettings #195

Merged
merged 21 commits into from
Sep 7, 2019
Merged

Refactor PBESettings #195

merged 21 commits into from
Sep 7, 2019

Conversation

Kermalis
Copy link
Owner

@Kermalis Kermalis commented Jul 31, 2019 •
edited
Loading

Closes #176

Done:

  • Ability to convert PBESettings to and from bytes and strings
  • PBESettings.Equals() and PBESettings.IsReadOnly
  • Store PBESettings in replays and team json files
  • PBETeamShell (Also uses a single PBESettings object for the entire team)
  • Do not use PBESettings.MaxLevel for stat/damage calculation
  • Listen for PBESettings changes in TeamBuilderView, PBEMovesetBuilder, PBEIndividualValueCollection, PBEEffortValueCollection, PBEPokemonShell, and PBETeamShell

TODO:

  • PBEPokemonShell should be able to function without a PBETeamShell and should still work after being removed from one
  • Add public setters for PBESettings in PBEMovesetBuilder, PBEEffortValueCollection, PBEIndividualValueCollection, PBETeamShell, and PBEPokemonShell
  • Settings editor in client
  • Settings can cause data overflow in extreme situations #200

Kermalis added 21 commits July 31, 2019 19:17
@Kermalis
Create default settings constants
2ebcc0e
@Kermalis
Use settings constants where possible
06730c3
@Kermalis
Settings ToBytes, FromBytes, ToString, FromString
d856186
@Kermalis
Store settings in replays
9b8e3e0
@Kermalis
Add null catches in battle constructors
2f1c320 
It wasn't there previously because settings used to be a struct.
@Kermalis
Fix MaxStatChange check
499c011
@Kermalis
PBESettings.Equals()
f2c5f87
@Kermalis
Re-add PBETeamShell, include settings in team json files, move EventP…
9285b65 
…okemon.cs

Also fixes #196
@Kermalis
Add PBESettings.Equals(code)
c46af9a
@Kermalis
Do not use settings.MaxLevel in Psywave/Stat/Damage calculation
5d6dfc2
@Kermalis
PBESettings.IsReadOnly
7bd3530
@Kermalis
Require trainer names when submitting teams to the battle
bbcd5d3
@Kermalis
PBEUtils documentation update
dc6b615
@Kermalis
Some fixes cuz I'm dumb
ba7b47a
@Kermalis
Listen for settings changes in PBEPokemonShell and PBETeamShell, list…
3836b18 
…en for team size changes in TeamBuilderView
@Kermalis
Listen for settings changes in PBEMovesetBuilder
47b470e
@Kermalis
Update Settings.cs
954b9e7
@Kermalis
Load winner from battle replay
9162806
@Kermalis
Listen for settings changes in PBEIndividualValueCollection
99376ce
@Kermalis
Use a copy of the default settings in TeamBuilderView so we can edit
54a936d
@Kermalis
Listen for settings changes in PBEEffortValueCollection
8249ce4
@Kermalis Kermalis marked this pull request as ready for review September 7, 2019 21:25
@Kermalis Kermalis merged commit 08c5727 into master Sep 7, 2019
@Kermalis Kermalis deleted the refactor-settings branch September 7, 2019 21:25
@Kermalis Kermalis mentioned this pull request Sep 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings should be convertable to a string
1 participant
@Kermalis