added reportPassedTest, takeScreenshotsOnExpectFailures and additional prefix options #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added ability to take screenshot on specific expect statement failures vs at end of spec.
for both failed expect screenshots and spec done screenshots
ryan-ohern
changed the title
|
@ryan-ohern it will be merged? i need that!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reportPassedTest:
With my automated tests running frequently, I was looking for a way to only generate the html report if a spec/suite had a failure. Hopefully this option will be of use to someone else as well.
takeScreenshotsOnExpectFailures:
Allows for grabbing a screenshot as soon as an expect statement fails vs just at end of spec. Included in this was modifying the html report to write an array of screenshots per spec vs just one.
specDoneScreenshotPrefix & expectFailedScreenshotPrefix:
Allows for customizing a prefix to the filenames for these screenshots. I found this helpful when viewing multiple screenshots within one spec to quickly identify which one was the spec done screenshots vs expect failure screenshots.