Add and implement new set_rgb packet type #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -291,6 +291,11 @@ class SetOutputCommand(Message): | |||
| output_id = Uint8Field(0x01) | |||
| output_mode = OutputField(0x02) | |||
|
|
|||
| class SetOutputCommand(Message): | |||
There was a problem hiding this comment.
class needs a unique name (will clobber existing SetOutputCommand message type).
please add an extra line above (2 blank lines between classes)
|
Looks neat. Occurs to me that we probably need a new part of the docs to describe all the optional things that can be flipped on, like this, wiegand RFID, etc.. Opened separate issue #11. |
This packet allows setting the rgb values to attached RGB LEDs or LED strips
|
Doing some cleanup, unfortunately this has merge conflicts which I don't have time to fix. Not sure if there's interest in this feature so closing, but please rebase and re-open if there is & I'll get on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This packet allows setting the rgb values to attached RGB LEDs or LED strips.