Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing draft_rtr PR #38

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ on:
- reopened
- synchronize
- labeled # benchmarks label required
- ready_for_review
workflow_dispatch:

env:
Expand All @@ -29,8 +30,9 @@ defaults:

jobs:
build:
if: github.repository_owner == 'tardis-sn' &&
if:
(github.event_name == 'push' ||
(!github.event.pull_request.draft) ||
github.event_name == 'workflow_dispatch' ||
(github.event_name == 'pull_request_target' &&
contains(github.event.pull_request.labels.*.name, 'benchmarks')))
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ on:
- reopened
- synchronize
- labeled # requires the `build-docs` label
- ready_for_review

workflow_dispatch: # manual trigger

Expand All @@ -37,6 +38,7 @@ defaults:
jobs:
check-for-changes:
runs-on: ubuntu-latest
if: ${{ !github.event.pull_request.draft }}
outputs:
trigger-check-outcome: ${{ steps.trigger_check.outcome }}
docs-check-outcome: ${{ steps.docs_check.outcome }}
Expand Down
14 changes: 8 additions & 6 deletions .github/workflows/stardis-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,17 @@ name: stardis-tests
on:
push:
branches:
- '*'
- master

pull_request:
branches:
- '*'

types:
- opened
- reopened
- synchronize
- ready_for_review
workflow_dispatch:

defaults:
Expand All @@ -22,18 +27,15 @@ jobs:
build:
strategy:
matrix:
label: [osx-64, linux-64]
label: [linux-64]
include:
- os: ubuntu-latest
label: linux-64
prefix: /usr/share/miniconda3/envs/stardis

- os: macos-latest
label: osx-64
prefix: /Users/runner/miniconda3/envs/stardis

name: ${{ matrix.label }}
runs-on: ${{ matrix.os }}
if: ${{ !github.event.pull_request.draft }}
steps:
- uses: actions/checkout@v4
with:
Expand Down
1 change: 0 additions & 1 deletion benchmarks/spectrum_formal_integral.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ def time_FormalIntegrator_functions(self):
self.simulation_verysimple.simulation_state, self.simulation_verysimple.plasma, self.simulation_verysimple.transport
)
FormalIntegrator.calculate_spectrum(self.simulation_verysimple.spectrum_solver.spectrum_real_packets.frequency)
FormalIntegrator.make_source_function()
FormalIntegrator.generate_numba_objects()
FormalIntegrator.formal_integral(
self.simulation_verysimple.spectrum_solver.spectrum_real_packets.frequency,
Expand Down
6 changes: 0 additions & 6 deletions docs/faq.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,6 @@ Usage

My simulation seems to consume excessive amounts of memory
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^


High memory usage can have many reasons. Both your model
and certain simulation settings can increase the memory
usage significantly

1. Enabling ``track_rpacket: true`` will take up substantial
amounts of memory, in particular for higher packet counts.
Consider turning this feature off or only use it with a
Expand Down
Loading