fix(1094): Keep current visibility when adding a new entity to the ca…

[tplevko]

…nvas

fixes #1094

vokoscreenNG-2024-11-13_15-03-55.mp4

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@39c0ffd). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...sualization/ContextToolbar/NewEntity/NewEntity.tsx	20.00%	12 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1615   +/-   ##
=======================================
  Coverage        ?   79.88%           
  Complexity      ?      273           
=======================================
  Files           ?      280           
  Lines           ?     8030           
  Branches        ?     1541           
=======================================
  Hits            ?     6415           
  Misses          ?     1555           
  Partials        ?       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lordrip]

@tplevko we now have the getVisualizationNodesFromGraph function to look for canvas nodes.

      setTimeout(() => {
        const result = getVisualizationNodesFromGraph(
          controller.getGraph(),
          (vizNode) => vizNode.data.entity?.id === newId,
        );

        controller.fireEvent(SELECTION_EVENT, [result[0]?.id]);
      }, 300);

That being said, I don't know a better way to ensure the selection happens after the rerender 😢 , so probably what's gonna happen for environments like DevSpaces, this might fail from time to time, since the SELECTION_EVENT could happen before the actual rerender.

Would you be open to moving forward without the setTimeout for now until we get a better way to ensure the entity is properly selected?