-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT]: Implement a Merkle Tree #161
Merged
coxmars
merged 6 commits into
KaizeNodeLabs:main
from
beeguy74:FEAT-Implement-a-Merkle-Tree
Feb 18, 2025
Merged
[FEAT]: Implement a Merkle Tree #161
coxmars
merged 6 commits into
KaizeNodeLabs:main
from
beeguy74:FEAT-Implement-a-Merkle-Tree
Feb 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@danielcdz I am ready for review, sir! 🦺 |
danielcdz
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do you have some comments on this? should i change something? |
coxmars
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your effort 🫡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 [FEAT]: Implement a Merkle Tree
🛠️ Issue
📖 Description
Implementation of a Merkle Tree contract. The contract handles the creation of Merkle trees and verification of data inclusion using Merkle proofs. I provided series of unit tests to ensure that all works fine.
build_tree
returns the hashes of the nodes in the Merkle tree;get_root
returns the hash root of the tree;verify
requires Merkle proof array, hash root, hash of the value being verified and its index in the original data arraygenerate_merkle_proof
requires the index of the target value and the length of initial data array📝 Additional Notes
I refined the Merkle tree implementation from 'Starknet by Example': I added a support for odd input data arrays so provided tree is built as follows: