Feat: string utility library #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coxmars
requested changes
Feb 12, 2025
There was a problem hiding this comment.
@armaanansari121 Great job, it looks pretty good to me. Also, can you create a .tool-versions please 🫡
Sure give me a minute. |
|
The changes have been made, ser. |
|
@coxmars seems like the crowdfunding contract has some failing tests. Please let me know if I need to change anything. |
danielcdz
reviewed
Feb 13, 2025
examples/cairo/scripts/string_utility/tests/test_contract.cairo
Outdated
Show resolved
Hide resolved
|
Done ser! @danielcdz |
danielcdz
approved these changes
Feb 13, 2025
|
@armaanansari121 looks pretty clean, thanks for your collaboration! |
|
Thank you very much. Looking forward to more contributions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Feat: String utility library
🛠️ Issue
📖 Description
Implemented the string library with the following components.
Stringstruct which represents the String that we are working with.newmethod to create an empty string.lenmethod to retrieve the length of the string.concatenatemethod to safely concatenate two strings, This method takes a reference to the string to which another string is to be concatenated.starts_withmethod to check if a string starts with a substring.ends_withmethod to check if a string ends with a substring.🖼️ Screenshots - Tests
📝 Additional Notes