Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL tutorial ex3 fixes #458

Merged
merged 3 commits into from
Jan 22, 2024
Merged

SQL tutorial ex3 fixes #458

merged 3 commits into from
Jan 22, 2024

Conversation

mcbex
Copy link
Contributor

@mcbex mcbex commented Jan 10, 2024

I noticed exercise 3 in the intro to SQL tutorial was broken. The tutorial and exercise notebooks still reference the BigQuery public hacker news dataset comments table. This dataset has been updated and now only contains one table: full.

The first query in the exercise doesn't work as nicely using the full table because one of the columns used is called by and needs to be quoted. However this PR attempts to fix the issue by referencing the correct table and adding a note in the tutorial about reserved words.

Related discussion post on Kaggle:
https://www.kaggle.com/learn/intro-to-sql/discussion/417044#2316394

Copy of the tutorial notebook with proposed changes applied:
https://www.kaggle.com/mmcbex/sql-tutorial-3-updated

Fixes:
#452

A couple follow up issues related to this one:

  • In tutorial 1, the hacker news dataset is also explored and the missing tables are mentioned. Unfortunately there is a nice diagram that is now outdated.
  • Exercises 1 and 2 in the Intro to SQL course add the hacker news dataset but do not use them. I believe those could be removed by deleting the references in this file but maybe out of scope for this PR.
  • An updated version of the dataset could be published on Kaggle. I will report the dataset as outdated and include a like to this PR for context (my report failed with an internal error 🤷‍♀️).

Copy link

google-cla bot commented Jan 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pculliton
Copy link
Member

Thank you, Ming! We really appreciate this PR and your contribution.

@pculliton pculliton merged commit 3a07d14 into Kaggle:master Jan 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants