-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab width #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lievenhey
force-pushed
the
tab-width
branch
2 times, most recently
from
May 2, 2024 14:35
aa6de85
to
af038e8
Compare
milianw
requested changes
May 2, 2024
lievenhey
force-pushed
the
tab-width
branch
2 times, most recently
from
May 3, 2024 09:21
6c1a8c4
to
23ca904
Compare
lievenhey
force-pushed
the
tab-width
branch
2 times, most recently
from
May 3, 2024 09:25
39b3c97
to
f67a264
Compare
milianw
approved these changes
May 6, 2024
void setTabWidthInPixels(int tabWidthInPixels) | ||
{ | ||
m_tabWidthInPixels = tabWidthInPixels; | ||
m_layout = nullptr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.reset()
is more expressive
This patch allows the user to set a custom width for \t. Since we use a monospace font we can simply use a multiple of the character width. This is done by settings the tabstopdistance of the QTextOption property of QTextLayout. closes: #583
milianw
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.