Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate release #627

Merged
merged 5 commits into from
May 3, 2024
Merged

Automate release #627

merged 5 commits into from
May 3, 2024

Conversation

lievenhey
Copy link
Contributor

This PR adds an automatic latest release aswell as release-please which provides a pr that can be merged to create a new release.

closes: #605

@lievenhey
Copy link
Contributor Author

I am not sure if the build-appimage pipeline should be deactivated on the master branch, since the create-latest-release pipeline will take care of that.

@lievenhey lievenhey requested a review from milianw April 29, 2024 13:09
@lievenhey lievenhey force-pushed the automate-release branch 2 times, most recently from 3f75554 to f1c8def Compare April 29, 2024 13:21
lievenhey added 5 commits May 2, 2024 12:06
@lievenhey
ci: add automatic latest release
1c8301c
@lievenhey
ci: enforce conventional commits
9468f13 
This allows us to automatically create a change log.
To use this feature locally it requires you to run:
pre-commit install --hook-type commit-msg
@lievenhey
ci: add automatic release pr
5c3afbe 
This creates a special pr that will automatically create a new release
when merged.
@lievenhey
ci: fix pre-commit pipeline not run on master branch
3daa7a9
@lievenhey
ci: fix failure when checking CHANGELOG.md
c3a7f27 
This file is generate so we do not need to run the formatter against it.
@lievenhey lievenhey force-pushed the automate-release branch from 8a3db16 to c3a7f27 Compare May 2, 2024 10:06
milianw
milianw approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@milianw milianw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

@lievenhey lievenhey merged commit 728d74b into master May 3, 2024
25 checks passed
@lievenhey lievenhey deleted the automate-release branch May 3, 2024 09:24
@GitMensch
Copy link
Contributor

GitMensch commented May 3, 2024 •
edited
Loading

I currently fail to understand that - the idea is that for each commit on master there is a "continuous" release, no?
Then I don't see where that release is, which then would solve the now closed #605.

@lievenhey
Copy link
Contributor Author

https://github.com/KDAB/hotspot/releases/tag/continuous here but it seems I need to figure something out since it was marked as draft. Will deal with this on Monday. Good find, thanks.

@GitMensch
Copy link
Contributor

Ah, now I see that as it should be: a pre-release release. If that is automatically updated, then this would be fine.
Can you adjust it so that it gets an additional asset with a fixed name like hoptspot-continuous.AppImage?
Note: interesting to see that the release-push via GH action allows an .AppImage, while @milianw couldn't upload that extension (I assume via GH online adjustment of the release) any more and needed to gzip that up-front.
Maybe it won't work over the GH API in the future, or it would be useful to do it similar for "real releases".

@lievenhey
Copy link
Contributor Author

Done, seems like ether ncipollo/release-action or github automatically add a draft tag. Now I use the github cli to remove that tag.

I don't think changing the name to hotspot-continuous.AppImage is a good idea. The current name is a perfect description of the commit that was used to build the appimage. If we get a bug report we can then use the name to identify which exact version was used. Maybe the bug is already fixed but the user didn't update, etc ...

@GitMensch
Copy link
Contributor

./hotspot... --version has the output, as well as the version info in the GUI.
The idea here is to get a stable download URL, and for that we need - additional to the updated release - an identical name.

If you still want the versioned name: what do you think about having the appimage twice (once with a stable name)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milianw milianw milianw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest AppImage download without GitHub account
3 participants
@lievenhey @GitMensch @milianw