Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CallerCallee add jump to source location in disassembly #573

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

lievenhey
Copy link
Contributor

this patch adds a context menu that allows the user to select if he wants to open the source code or opens the disassembly and focus the selected location

closes: #515

@lievenhey lievenhey linked an issue Dec 12, 2023 that may be closed by this pull request
@lievenhey
Copy link
Contributor Author

lievenhey commented Dec 12, 2023

@GitMensch I added some prototype jumping the the disassembler. You can ether press F6 (all good shortcuts were already in use) to open a goto menu or use the context menu to jump to a specific line (source code only currently).
I know it is a bit clunky but I am trying to figure out what is the best way to add some navigation.

I would like to hear which method work best. (Yes the context menu is hard to use currently / broken, I will fix that later as well as adding it to the assembly side)

@GitMensch
Copy link
Contributor

Thank you for working on this.

I did check the location pane in caller/callee tab and do see both context menu entries - but

  • in one case (sourcefile deleted) there is no context menu at all, no message, no output in stderr/logging
  • in all others the Disassembly entry did not do anything (also no output in stderr/logging), while "open in file" does work and positions to the right place and Disassembly on the function level (all other panes and views) works fine

Checking F6 yields in the "go to line" being shown, placing "115" in there and pressing Enter does not seem to work either.

Note: all of CTRL+F (in both panes) and F6 (only on the source) has a remarkable time (1-2 seconds) to be shown ?!?

In any case: CTRL+G is already taken, what about ALT+G or CTRL+SHIFT+G?

src/resultscallercalleepage.cpp Outdated Show resolved Hide resolved
src/resultscallercalleepage.cpp Show resolved Hide resolved
src/resultsdisassemblypage.cpp Outdated Show resolved Hide resolved
src/resultsdisassemblypage.cpp Outdated Show resolved Hide resolved
src/resultscallercalleepage.cpp Outdated Show resolved Hide resolved
src/resultsdisassemblypage.cpp Outdated Show resolved Hide resolved
src/resultsdisassemblypage.cpp Outdated Show resolved Hide resolved
src/resultsdisassemblypage.cpp Outdated Show resolved Hide resolved
@lievenhey lievenhey force-pushed the better-navigation branch 4 times, most recently from a37da97 to 2dff7c0 Compare January 9, 2024 15:10
@lievenhey
Copy link
Contributor Author

I added it also for the disassembly, but it doesn't work there (currently)

@lievenhey lievenhey requested a review from milianw January 9, 2024 15:15
src/resultscallercalleepage.h Outdated Show resolved Hide resolved
src/resultsdisassemblypage.cpp Outdated Show resolved Hide resolved
src/resultsdisassemblypage.cpp Outdated Show resolved Hide resolved
src/resultsdisassemblypage.cpp Outdated Show resolved Hide resolved
src/resultsdisassemblypage.cpp Outdated Show resolved Hide resolved
src/resultsdisassemblypage.ui Outdated Show resolved Hide resolved
this patch adds a context menu that allows the user to select if he
wants to open the source code or opens the disassembly and focus the
selected location

closes: #515
this allows to user to quickly jump to a location without scrolling

closes: #541
@milianw milianw merged commit 5addd4f into master Jan 13, 2024
23 checks passed
@milianw milianw deleted the better-navigation branch January 13, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants