Use method calls to initialize dependencies #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonMatthesKDAB
force-pushed
the
1166-call-initializers
branch
3 times, most recently
from
fc2ed2a to
9b66808
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1169 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 12426 12426
=========================================
Hits 12426 12426 ☔ View full report in Codecov by Sentry. |
LeonMatthesKDAB
force-pushed
the
1166-call-initializers
branch
11 times, most recently
from
d526f5e to
b1d679c
Compare
LeonMatthesKDAB
force-pushed
the
1166-call-initializers
branch
from
b1d679c to
de942a1
Compare
LeonMatthesKDAB
force-pushed
the
1166-call-initializers
branch
4 times, most recently
from
89d86e8 to
4188ac1
Compare
ahayzen-kdab
reviewed
Feb 6, 2025
ahayzen-kdab
reviewed
Feb 6, 2025
ahayzen-kdab
reviewed
Feb 6, 2025
ahayzen-kdab
reviewed
Feb 6, 2025
ahayzen-kdab
reviewed
Feb 6, 2025
LeonMatthesKDAB
force-pushed
the
1166-call-initializers
branch
from
4188ac1 to
6890ce6
Compare
This speeds up rebuilds, as we only need to link to upstream dependencies initializers, not build their initializers every time. It should also allow us to manually initialize certain libraries down the line with something similar to Q_INIT_RESOURCE, etc. Closes KDAB#1166
LeonMatthesKDAB
force-pushed
the
1166-call-initializers
branch
from
6890ce6 to
4f52e11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up rebuilds, as we only need to link to upstream
dependencies initializers, not build their initializers every time.
It should also allow us to manually initialize certain libraries down
the line with something similar to Q_INIT_RESOURCE, etc.
Closes #1166