Skip to content

Commit

Permalink
haskellPackages.ghc-settings-edit: avoid the use of filesets
Browse files Browse the repository at this point in the history
This should be 0 rebuilds, except it fixes the installer tests, as
lib.filesets is somehow broken when combining chroot stores with
channel references (???).

Running nixosTests.installer.simple with this reverted will reproduce
the issue consistently.

CC @infinisil
  • Loading branch information
K900 committed Oct 5, 2024
1 parent 1b42ea0 commit 9806325
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions pkgs/development/tools/haskell/ghc-settings-edit/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,10 @@
mkDerivation {
pname = "ghc-settings-edit";
version = "0.1.0";
src = lib.fileset.toSource {
root = ./.;
fileset = lib.fileset.unions [
./Setup.hs
./ghc-settings-edit.lhs
./ghc-settings-edit.cabal
];
src = builtins.path {
path = ./.;
name = "source";
filter = path: _: (builtins.baseNameOf path) != "default.nix";
};
isLibrary = false;
isExecutable = true;
Expand Down

5 comments on commit 9806325

@infinisil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably caused by NixOS/nix#11503

@K900
Copy link
Owner Author

@K900 K900 commented on 9806325 Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So like, does this mean we just can't use filesets in nixpkgs right now?

@infinisil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess not when it needs to be used in VMs or so :/

@K900
Copy link
Owner Author

@K900 K900 commented on 9806325 Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem isn't VMs but chroot stores, so anything that could be used by nixos-install is affected... Can we somehow work around this in lib.filesets?

@infinisil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Afraid we can't work around it without compromising correctness of lib.fileset :/

Please sign in to comment.