Issue #521 Closes #521 #529
Conversation
There was a problem hiding this comment.
Overall looks good. Just a couple of small things:
- The profile image for Cat is much higher resolution and should probably be used in the merged profile.
- The now unused images should be deleted from the images directory to help keep the repo size to a minimum (
static/images/people)
|
Sounds good, I will make the mentioned changes. Thanks for the review.
…On Sat, Mar 18, 2023, at 3:06 PM, Ryan Goodwin - notifications at github.com wrote:
***@***.**** requested changes on this pull request.
Overall looks good. Just a couple of small things:
1. The profile image for Cat is much higher resolution and should probably be used in the merged profile.
2. The now unused images should be deleted from the images directory to help keep the repo size to a minimum (`static/images/people`)
—
Reply to this email directly, view it on GitHub <#529 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQKXMNKVL6QU7AA3TI4UMTLW4YIVZANCNFSM6AAAAAAV7UIJYM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Don't forget about Jerome's duplicate image |
|
I will get that removed and resubmitted
…On Sat, Mar 18, 2023, at 3:56 PM, Ryan Goodwin - notifications at github.com wrote:
Don't forget about Jerome's duplicate image
—
Reply to this email directly, view it on GitHub <#529 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQKXMNKZZNUFBV2VVOJAMGTW4YOPRANCNFSM6AAAAAAV7UIJYM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
There was a problem hiding this comment.
This LGTM.
Here are new merged people:
The new https://www.jupiterbroadcasting.com/guests/catherine-kretzschmar/
The new https://www.jupiterbroadcasting.com/guests/jeromelaban/
|
Closes #512 |
This reverts commit 4eda6f5. This is to correct the issue with the commits made on 3/24/23. Big thanks for Master cg_bassplayer for showing this Padawan the way.
There was a problem hiding this comment.
So it looks like this file is still here even after our chat the other day. I would try the git revert again, but I did forget 1 important thing about it. It needs to be git revert <commit-hash>..HEAD to get all the changes undone. source
Shoot me a message if you need help with this.
There was a problem hiding this comment.
So it looks like this file is still here even after our chat the other day. I would try the git revert again, but I did forget 1 important thing about it. It needs to be
git revert <commit-hash>..HEADto get all the changes undone. sourceShoot me a message if you need help with this.
I understand. I will perform the outline steps and message you with any questions.
|
I will make a new PR to close #521 via a new branch. |
Merched the following files and then updated the show notes for each episode they were in. #521
Closes #521