Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update (menu): Change radar display method to SetMinimapType #51

Closed
wants to merge 1 commit into from

Conversation

hardbaited
Copy link

This should fix the minimap issue on rsg. (Only tested for rsg but should work the same with all the frameworks)

@hardbaited
Copy link
Author

hardbaited commented Feb 8, 2025

Tested on 1.15.0.beta.2 and it works

@hardbaited hardbaited mentioned this pull request Feb 8, 2025
@KadDarem
Copy link
Contributor

KadDarem commented Feb 8, 2025

Unfortunately, RSG use this native to manage the map: https://rdr3natives.com/?_0x5FB53015

The native to get the minimap type doesn't exist. So it will be hard to fix this issue

@hardbaited
Copy link
Author

You dont need to get the minimap type? i think? Cause when i changed the DisplayRadar(not show) native to the one rsg uses SetMinimapType(0) the minimap shows up correctly after that

@KadDarem
Copy link
Contributor

KadDarem commented Feb 8, 2025

RSG set the minimap type to 0. But another framework can set it to 1 or 2 or 3. So I need to get the type before opening the menu to apply again the right type after his closing. It's what I currently do with IsRadarHidden().

The real issue is : why IsRadarHidden() return true when the minimap type is set to 0.

@hardbaited
Copy link
Author

it actually makes sense that the isRadarHidden returns true when the minimap type is 0 since 0 hides the radar. As i said in the desc of the pr i tested it only on rsg.

@KadDarem
Copy link
Contributor

KadDarem commented Feb 8, 2025

Unfortunately, your PR only works on RSG, not on all other frameworks/scripts that hide the map with DisplayRadar().
I'm surprised to discover that RSG doesn't use this native.

I'm sorry but I can't accept your PR for this reason.

@hardbaited
Copy link
Author

alright should i close the pr?

@KadDarem
Copy link
Contributor

KadDarem commented Feb 9, 2025

Yes, you can close it.

I will investigate on other native to check if I can get the minimap type and apply the right one. Like with IsBigmapActive()

@hardbaited hardbaited closed this Feb 15, 2025
@KadDarem
Copy link
Contributor

I sent a PR to R* to add the GetMinimapType() native: citizenfx/fivem#3150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants