Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve finalizer safety for Session, SshChannel, and SftpSession #31

Merged
merged 1 commit into from
Dec 20, 2024

Improve finalizer safety for Session, SshChannel, and SftpSession

1d6c838
Select commit
Loading
Failed to load commit list.
Merged

Improve finalizer safety for Session, SshChannel, and SftpSession #31

Improve finalizer safety for Session, SshChannel, and SftpSession
1d6c838
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 20, 2024 in 1s

83.29% (-0.02%) compared to c4120e3

View this Pull Request on Codecov

83.29% (-0.02%) compared to c4120e3

Details

Codecov Report

Attention: Patch coverage is 84.84848% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.29%. Comparing base (c4120e3) to head (1d6c838).

Files with missing lines Patch % Lines
src/session.jl 75.00% 2 Missing ⚠️
src/sftp.jl 89.47% 2 Missing ⚠️
src/channel.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   83.31%   83.29%   -0.02%     
==========================================
  Files          10       10              
  Lines        1954     1976      +22     
==========================================
+ Hits         1628     1646      +18     
- Misses        326      330       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.