Skip to content

Commit

Permalink
Temporarily disable the safe part of _safe_poll_fd()
Browse files Browse the repository at this point in the history
It seems to be causing something to spin. Should be replaced with a different
design anyway.
  • Loading branch information
JamesWrigley committed Oct 6, 2024
1 parent 96ebdbd commit 78f2686
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions src/LibSSH.jl
Original file line number Diff line number Diff line change
Expand Up @@ -162,16 +162,19 @@ end
# versions between the loop condition evaluation and this line, so we wrap
# poll_fd() in a try-catch in case the bind (and thus the file descriptor) has
# been closed in the meantime, which would cause poll_fd() to throw an IOError:
# https://github.com/JuliaLang/julia/pull/52377
# https://github.com/JuliaLang/julia/pull/52377.
#
# Note: the whole polling design is bad. We should only have one task polling
# the session and waking up other listeners.
function _safe_poll_fd(args...; kwargs...)
result = nothing
try
# try
result = FileWatching.poll_fd(args...; kwargs...)
catch ex
if !(ex isa Base.IOError)
rethrow()
end
end
# catch ex
# if !(ex isa Base.IOError)
# rethrow()
# end
# end

return result
end
Expand Down

0 comments on commit 78f2686

Please sign in to comment.