Skip to content

Commit

Permalink
Add tests for x86
Browse files Browse the repository at this point in the history
  • Loading branch information
JamesWrigley committed Oct 27, 2024
1 parent 045bee1 commit 6324809
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 4 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ jobs:
- ubuntu-latest
arch:
- x64
- x86
exclude:
- os: macOS-latest
arch: x86
include:
- version: '1.9'
allow_failure: false
Expand Down
2 changes: 1 addition & 1 deletion src/channel.jl
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ $(TYPEDSIGNATURES)
Sends an exit status in reponse to an exec request. Wrapper around
[`lib.ssh_channel_request_send_exit_status()`](@ref).
"""
function channel_request_send_exit_status(sshchan::SshChannel, status::Int)
function channel_request_send_exit_status(sshchan::SshChannel, status::Integer)
if !isopen(sshchan)
throw(ArgumentError("SshChannel has been closed, cannot send exit status"))
end
Expand Down
10 changes: 7 additions & 3 deletions test/LibSSHTests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,10 @@ end
mktempdir() do tmpdir
@test readchomp("cd $(tmpdir) && pwd", session) == tmpdir
end

sshchan = ssh.SshChannel(session)
close(sshchan)
@test_throws ArgumentError ssh.channel_request_send_exit_status(sshchan, 0)
end
end

Expand Down Expand Up @@ -1044,8 +1048,8 @@ end
@test ssh.lib_version() isa VersionNumber
end

# @testset "Aqua.jl" begin
# Aqua.test_all(ssh)
# end
@testset "Aqua.jl" begin
Aqua.test_all(ssh)
end

end

0 comments on commit 6324809

Please sign in to comment.