WIP: Parallelize evaluation of solvers in bmark_solvers #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpo
reviewed
Sep 5, 2022
| """ | ||
| function bmark_solvers(solvers::Dict{Symbol, <:Any}, args...; kwargs...) | ||
| function bmark_solvers(solvers::Dict{Symbol, <:Any}, args...;parallel_eval=false, kwargs...) |
There was a problem hiding this comment.
is this mandatory? what happens if we try to run the benchmarks in parallel and there is only 1 proc?
There was a problem hiding this comment.
it's mandatory to set parallel_eval=true if you want to benchmark in parallel. If you still have 1 proc, it won't do it in parallel. I added this keyword in case the user is handling multiple procs and does not want evaluate solvers in parallel. We could get rid of it it's not necessary.
There was a problem hiding this comment.
Ok we could leave it, at least for debugging, but let's set it to true by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to allow the user to parallelize the evaluation of solvers when using the
bmark_solvers(solvers, problems;...)method. It can be run in parallel locally or with any form of distributed computing backend supported byClusterManagers.jl.Currently, there are a couple of issues: