Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polygon #167

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Add polygon #167

merged 2 commits into from
Apr 22, 2022

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Apr 22, 2022

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #167 (7a083e1) into main (3341bbf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files         715      718    +3     
  Lines        6240     6281   +41     
=======================================
+ Hits         6212     6253   +41     
  Misses         28       28           
Impacted Files Coverage Δ
src/ADNLPProblems/polygon.jl 100.00% <100.00%> (ø)
src/Meta/polygon.jl 100.00% <100.00%> (ø)
src/PureJuMP/polygon.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3341bbf...7a083e1. Read the comment docs.

@tmigot
Copy link
Member Author

tmigot commented Apr 22, 2022

I think we miss the initial guess for this one. Couldn't really read it here https://bitbucket.org/optrove/sif/src/master/POLYGON.SIF or not clear in the COPS report.

@dpo
Copy link
Member

dpo commented Apr 22, 2022

@tmigot
Copy link
Member Author

tmigot commented Apr 22, 2022

Here's one: https://vanderbei.princeton.edu/ampl/nlmodels/polygon/polygon2.mod

Great, thanks! I adapted it to the current model.

@tmigot tmigot merged commit 11a137e into main Apr 22, 2022
@tmigot tmigot deleted the add-polygon branch April 22, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants