Allow Modules as propagation method, remove :auto
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
========================================
+ Coverage 88.2% 88.4% +0.2%
========================================
Files 26 26
Lines 1821 1788 -33
========================================
- Hits 1605 1579 -26
+ Misses 216 209 -7 ☔ View full report in Codecov by Sentry. |
goerz
force-pushed
the
no-auto-method
branch
2 times, most recently
from
01e483a to
9932d73
Compare
In preparation for allowing for ODE solvers via an optional dependency, we now allow (and encourage) passing modules as a propagation `method`. Also, the `method` now must be explicitly specified, `:auto` is no longer an option. The heuristics for choosing a propagation methods are brittle, and it's probably a good idea for people to think about which method they should use anyway. With optional dependencies (ODE) being added, automatically choosing a method becomes even weirder.
goerz
force-pushed
the
no-auto-method
branch
from
9932d73 to
d421db0
Compare
|
Not sure why this is marked as "closed": it was properly merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for allowing for ODE solvers via an optional dependency, we now allow (and encourage) passing modules as a propagation
method.Also, the
methodnow must be explicitly specified,:autois no longer an option. The heuristics for choosing a propagation methods are brittle, and it's probably a good idea for people to think about which method they should use anyway.With optional dependencies (ODE) being added, automatically choosing a method becomes even weirder.