Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #37

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Fix tests #37

merged 1 commit into from
Jul 15, 2024

Conversation

timholy
Copy link
Member

@timholy timholy commented Jul 13, 2024

The random seed is not stable across Julia versions, so the random
matrices are not consistent. On Julia 1.10 (and some other versions too),
the random matrix in sparse_test is not full rank, so the test fails.
This adds a small diagonal to ensure it has full rank.

The random seed is not stable across Julia versions, so the random
matrices are not consistent. On Julia 1.10 (and some other versions too),
the random matrix in `sparse_test` is not full rank, so the test fails.
This adds a small diagonal to ensure it has full rank.
@timholy timholy mentioned this pull request Jul 13, 2024
@JeffFessler
Copy link
Member

@ahwillia would you mind adding @timholy as a maintainer of this package so that he can do this work more easily? I can approve his workflow runs but I do not have privileges to add maintainers.

Perhaps ideally this package would get put in some organization where there might be a set of possible maintainers, but I am unsure which of the many optimization-related orgs would fit it best.

@JeffFessler
Copy link
Member

Seems to be some error in the pycall.

@ahwillia
Copy link
Collaborator

Done. Also happy to transfer the package somewhere else if helpful.

@timholy
Copy link
Member Author

timholy commented Jul 14, 2024

@JeffFessler
Copy link
Member

That org makes sense because it already has other solvers like:
https://github.com/JuliaLinearAlgebra/IterativeSolvers.jl

@timholy timholy force-pushed the teh/fix_tests branch 2 times, most recently from 439d475 to 3488b65 Compare July 15, 2024 10:13
@timholy
Copy link
Member Author

timholy commented Jul 15, 2024

With regard to the scipy failure, to me it looks like we're being bitten by scipy/scipy#21140. As that will clearly resolve itself (see scipy/scipy#21021), and tests pass for me locally, I think we should just ignore it for now.

@timholy timholy merged commit 5c3b2cc into JuliaLinearAlgebra:master Jul 15, 2024
0 of 18 checks passed
@timholy timholy deleted the teh/fix_tests branch July 15, 2024 10:48
@ahwillia
Copy link
Collaborator

@timholy, I tried to initiate the transfer but gives me an error message below. Do I need to be added to JuliaLinearAlgebra temporarily to make the transfer? Or is there a better way?

You don’t have the permission to create public repositories on JuliaLinearAlgebra

@timholy
Copy link
Member Author

timholy commented Jul 16, 2024

I think you'll need an invitation. I have that power 💪 . As a courtesy to the other owners of JuliaLinearAlgebra, I posted our plans on the slack #linear-algebra channel. It's possible someone will suggest an even better org. But if I haven't heard any objections by the end of today, I'll send you an invite to JuliaLinearAlgebra.

@timholy
Copy link
Member Author

timholy commented Jul 16, 2024

Invitation sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants