-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #37
Fix tests #37
Conversation
@ahwillia would you mind adding @timholy as a maintainer of this package so that he can do this work more easily? I can approve his workflow runs but I do not have privileges to add maintainers. Perhaps ideally this package would get put in some organization where there might be a set of possible maintainers, but I am unsure which of the many optimization-related orgs would fit it best. |
Seems to be some error in the pycall. |
Done. Also happy to transfer the package somewhere else if helpful. |
That org makes sense because it already has other solvers like: |
439d475
to
3488b65
Compare
With regard to the scipy failure, to me it looks like we're being bitten by scipy/scipy#21140. As that will clearly resolve itself (see scipy/scipy#21021), and tests pass for me locally, I think we should just ignore it for now. |
@timholy, I tried to initiate the transfer but gives me an error message below. Do I need to be added to
|
I think you'll need an invitation. I have that power 💪 . As a courtesy to the other owners of JuliaLinearAlgebra, I posted our plans on the slack |
Invitation sent. |
The random seed is not stable across Julia versions, so the random
matrices are not consistent. On Julia 1.10 (and some other versions too),
the random matrix in
sparse_test
is not full rank, so the test fails.This adds a small diagonal to ensure it has full rank.