Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a performance disclaimer to the banner #9123

Closed
wants to merge 1 commit into from
Closed

Add a performance disclaimer to the banner #9123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions base/version.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,9 @@ function banner(io::IO = STDOUT)
end
end
commit_date = GIT_VERSION_INFO.date_string != "" ? " ($(GIT_VERSION_INFO.date_string))": ""

disclaimer = """Note that the REPL is only meant for prototype development. If you are
interested in the performance of a piece of code, please put that code
inside of a function so that Julia's JIT compiler can optimize it."""
if have_color
tx = "\033[0m\033[1m" # text
jl = "\033[0m\033[1m" # julia
Expand All @@ -238,7 +240,9 @@ function banner(io::IO = STDOUT)
$(jl)_/ |\\__'_|_|_|\\__'_|$(tx) | $(commit_string)
$(jl)|__/$(tx) | $(Sys.MACHINE)

\033[0m""")
$(disclaimer)
\033[0m
""")
else
print(io,"""
_
Expand All @@ -250,6 +254,8 @@ function banner(io::IO = STDOUT)
_/ |\\__'_|_|_|\\__'_| | $(commit_string)
|__/ | $(Sys.MACHINE)

$(disclaimer)

""")
end
end