Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport matrix alignment fixes to 1.8 #47276

Closed
wants to merge 32 commits into from
Closed

backport matrix alignment fixes to 1.8 #47276

wants to merge 32 commits into from

Conversation

oscardssmith
Copy link
Member

@oscardssmith oscardssmith commented Oct 21, 2022 •
edited
Loading

backport of #45751 at request of @YingboMa

N5N3 and others added 8 commits September 30, 2022 09:26
@N5N3
Set intersection = 1 during intersect_sub_datatype (#46882)
df4c852 
(cherry picked from commit e6d9979)
@LilithHafner
Don't prompt field names for tuples at the REPL (#46897)
b4a3215 
(cherry picked from commit d5cde86)
@wsmoses
Don't crash on variable sized gc allocations (#46914)
76405ae 
(cherry picked from commit 8003563)
@ranocha
improve type stability of handle_message(logger, ... (#46906)
f8879a0 
(cherry picked from commit 6c0aa6d)
@perryprog
Don't error when transposing an empty buffer (#46925)
de63fdd 
(cherry picked from commit 757f21e)
@fredrikekre
Fix shift direction of circshift! for vectors (#46759)
e2c1b96 
This patch fixes the shifting direction for
circshift!(x::AbstractVector, n::Integer), which was opposite the
direction of circshift(x, n) and circshift!(y, x, n). In addition, this
patch fixes the method to also work correctly with offset arrays.
Fixes #46533.

(cherry picked from commit f1c4d54)
bump SparseArrays to latest release-1.8
f5c2cfb
@staticfloat
[win] Backport win MSYS2 build pr (#46988)
7c4ac37 
* Build/win: Build with MSYS2 (#46140)

* Makefile: MSYS2: close path conversion for `DEP_LIBS`

Automatic path conversion will replace `:` with `;`

* Makefile: MSYS2: use `cygpath` for path convert

ref: https://www.msys2.org/docs/filesystem-paths/#manual-unix-windows-path-conversion

* devdoc/win/msys2: add build steps

* devdoc/win/msys2: Add x86/x64 build notes

* devdoc/win/msys2: apply sugestions

Co-Authored-By: Elliot Saba <[email protected]>

* Instead of `CC_WITH_ENV`, scope environment variables to targets

* Fix whitespace

Co-authored-by: Elliot Saba <[email protected]>

* Disable MSYS2's path munging for `stringreplace` (#46803)

This was causing our rewriting of the loader's RPATH emulation to fail
after running `make install`, as MSYS2 was rewriting our list that looks
like:

```
../bin/libgcc_s_seh-1.dll:../bin/libopenlibm.dll:@../bin/libjulia-internal.dll:@../bin/libjulia-codegen.dll:
```

Into one that looked like:
```
..\bin\libgcc_s_seh-1.dll;..\bin\libopenlibm.dll;@..\bin\libjulia-internal.dll;@..\bin\libjulia-codegen.dll;
```

By exporting `MSYS2_ARG_CONV_EXCL='*'` for all `stringreplace`
invocations, we dodge this issue, as documented by MSYS2 [0].

[0] https://www.msys2.org/wiki/Porting/#filesystem-namespaces

* [win] Disable MSYS2 path munging when calling `is.exe` (#46867)

Tragically, I believe MSYS2 is messing with options such as
`/VERYSILENT` turning them instead into `C:\msys2\VERYSILENT` or
similar.

Co-authored-by: Elliot Saba <[email protected]>
@oscardssmith oscardssmith added unicode Related to unicode characters and encodings display and printing Aesthetics and correctness of printed representations of objects. labels Oct 21, 2022
@oscardssmith oscardssmith requested review from DilumAluthge and a team as code owners October 21, 2022 17:37
@oscardssmith oscardssmith changed the base branch from master to backports-release-1.8 October 21, 2022 17:38
@DilumAluthge DilumAluthge removed request for a team and DilumAluthge October 21, 2022 17:39
maleadt and others added 15 commits October 27, 2022 13:00
@maleadt
Fix serialization of code instances (#46373)
ae47a3d
@DilumAluthge
Base.stale_cachefile: allow ftime_req to be greater than ftime …
612e3d9 
…by up to one microsecond (to compensate for Windows tar) (#45552)

(cherry picked from commit 4c39647)
@Keno
Take into account color and unicode in matrix alignment (#45751)
f371bae 
Without this, alignment would count characters rather than
textwidth as well as counting inline escape sequences in
colored output. Fix that by using uncolored printing for
alignment and textwidth rather than number of codepoints.

(cherry picked from commit 626acd4)
@DilumAluthge
CI (Create Buildbot Statuses): remove tester_win64 and `tester_win3…
0238532 
…2` from the list (#46997)

(cherry picked from commit 6424f79)
@cjdoris
make CanonicalIndexError an Exception type (#47008)
952f987 
(cherry picked from commit 7085703)
@LilithHafner
Replace isfinite check in ranges with lo ≤ x ≤ hi (#45646)
b30daed 
Co-authored-by: Viral B. Shah <[email protected]>
(cherry picked from commit 5811825)
@staticfloat
gc: add missing root for binding->ty field (#46806)
f20222b 
Co-authored-by: Jameson Nash <[email protected]>
(cherry picked from commit 45b96c4)
@dkarrasch
Check sizes in 3-arg diagonal (dot-)product (#47114)
19a17b5 
(cherry picked from commit 25e3809)
@KristofferC
make REPL completions robust against expanduser throwing (#47058)
36c9188 
(cherry picked from commit 7beeaf7)
@ranocha
fix invalidations when loading ForwardDiff.jl (#47091)
d1b2980 
(cherry picked from commit 0dada17)
@wsmoses
optimizer: fix alloc opt on unknown offset with references (#47076)
d5784d2 
Fixes issued mentioned in #47075 (comment)

(cherry picked from commit a68235c)
@vtjnash
fix spelling of :not_atomic symbol default value (#47187)
2f77496 
(cherry picked from commit dc3a2e8)
@vtjnash
fix linkage of libuv (#47203)
7ea550d 
Only libjulia-internal is supposed to be linked against this, since it
is a static library.

Fix #47198

(cherry picked from commit e8aacc8)
@quinnj
Ensure port in listenany stays UInt16 (#47213)
c7d71a0 
As reported [here](https://discourse.julialang.org/t/test-failures-for-sockets-base-runtests-sockets/88898).

My guess on the original issue reported is that, for some reason, the host where the tests are run
is unable to listen on any ports, so we end up cycling through the entire UInt16 range (the test
starts at port 11011), but when we fail on port 65535, we do `addr.port + 1` and instead of wrapping
around as I believe this function intends to happen (as noted by the `addr.port == default_port` check
before we error), it gets promoted to `Int(65536)` which then throws an (unexpected) error in the `InetAddr`
constructor.

I'm not quite sure how to test this exactly though, because we'd need to simulate not being able
to listen on any ports? If anyone has any ideas, I'm all ears.

(cherry picked from commit a311f4d)
@vtjnash
[InteractiveUtils] win: handle empty clipboard errors (#47311)
f2f579a 
Fix #46981

(cherry picked from commit 0645427)
fingolfin and others added 8 commits October 27, 2022 13:28
@fingolfin
Better Libdl.dlopen error when using non-standard extension (#46998)
1a2f7ce 
When trying to dlopen a file with non-standard extension (e.g. `foo.so`
instead of `foo.dylib` when running on macOS), if this failed (e.g.
because of a reference to an undefined symbol), then instead of printing
the error message returned by `dlerror` with a helpful notice what
went wrong, a message indicating something to the effect that
"foo.so.dylib was not found" was shown, which was not helpful at all.

To get the actual helpful error message, add a check so that when dlopen
fails for a file that actually exists, we don't retry loading from a
file with the standard extension attached, which might not even exist;
instead we just give up.

This matches what is already being done for relative paths. This patch
simply copies the relevant check to also be applied to the case dealing
with absolute paths.

(cherry picked from commit a490197)
@vtjnash
ccall: handle Union appearing as a field-type without crashing (#46787)
3977585 
We disallow union as the direct type, so perhaps we should disallow it
as a field-type also, but since we do allow references in those cases
typically, we will allow this also.

Also DRY the emit_global code, since it had bit-rotted relative to the
usual code path through emit_globalref (and apparently could still be
run though for handling the first argument to cfunction).

Fix #46786

(cherry picked from commit ed01ee0)
@vtjnash
staticdata: avoid needing unaligned loads, support 64-bit images (#46683
e8f5ca8 
)

No functional changes intended here.

(cherry picked from commit 45623a8)
@Seelengrab @KristofferC
Add compat note for @testset foo() (#46980)
2dbdb51 
Co-authored-by: Sukera <[email protected]>
(cherry picked from commit 45fd204)
@vtjnash @KristofferC
subtype: fix miscount of Tuple Vararg matching
4ad6fed 
Fix #47246

(cherry picked from commit 17515cd)
@wsmoses @KristofferC
Fix GC assertion on array of derived pointers (#47299)
f683ed5 
* Fix GC assertion on array of derived pointers

* Add test

(cherry picked from commit d885fc7)
@apaz-cli @KristofferC
sysimg relocation lists now use LEB128 format (#47204)
7b2d05c 
Appears to reduce the data size from about 165MB to 147MB!

(cherry picked from commit 94736a4)
@JeffreySarnoff @KristofferC
bugfix: fld1 order of ops (#46938)
8c2b377 
* bugfix: fld1 order of ops

fixes #28973

(cherry picked from commit fcdc5bc)
@YingboMa
Copy link
Contributor

Bump. The test failure seems unrelated.

@giordano giordano changed the title backport allignment fixes to 1.8 backport matrix alignment fixes to 1.8 Oct 27, 2022
@DilumAluthge DilumAluthge force-pushed the oscardssmith-backport-allignment-fixes branch from 0d28d0b to 060324e Compare October 27, 2022 21:17
@KristofferC KristofferC force-pushed the backports-release-1.8 branch 2 times, most recently from 345ce31 to e78a9d2 Compare October 28, 2022 06:36
@KristofferC
Copy link
Member

PR got backport label added to it so it was automatically added to #46984 so this can be closed.

@KristofferC KristofferC closed this Nov 2, 2022
@DilumAluthge DilumAluthge deleted the oscardssmith-backport-allignment-fixes branch November 2, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
display and printing Aesthetics and correctness of printed representations of objects. unicode Related to unicode characters and encodings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.