Thread-safety improvements #122
Conversation
This should fix an exception seen in CI from the lingering timeout task:
```
Test Summary: | Pass Total Time
Deserialization error recovery and include() | 11 11 3.9s
From worker 4: Unhandled Task ERROR: EOFError: read end of file
From worker 4: Stacktrace:
From worker 4: [1] wait
From worker 4: @ .\asyncevent.jl:159 [inlined]
From worker 4: [2] sleep(sec::Float64)
From worker 4: @ Base .\asyncevent.jl:265
From worker 4: [3] (::DistributedNext.var"#34#37"{DistributedNext.Worker, Float64})()
From worker 4: @ DistributedNext D:\a\DistributedNext.jl\DistributedNext.jl\src\cluster.jl:213
```
.github/workflows/ci.yml
Outdated
| @@ -44,6 +44,7 @@ jobs: | |||
| - uses: julia-actions/julia-runtest@v1 | |||
| env: | |||
| JULIA_DISTRIBUTED_TESTING_STANDALONE: 1 | |||
| JULIA_NUM_THREADS: 4 | |||
There was a problem hiding this comment.
| JULIA_NUM_THREADS: 4 | |
| JULIA_NUM_THREADS: 4,4 |
Shake out having lots of threads in both pools?
There was a problem hiding this comment.
Yep makes sense; fixed in 2874281.
|
The test failures are coming from replacing I think it's best to be conservative with this update so I'm going to revert that commit. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 79.29% 79.50% +0.21%
==========================================
Files 10 10
Lines 1922 1918 -4
==========================================
+ Hits 1524 1525 +1
+ Misses 398 393 -5 ☔ View full report in Codecov by Sentry. |
The `launched_q` array is filled concurrently by the launcher tasks for each worker. Now it's wrapped inside `Base.Lockable` for thread-safety.
JamesWrigley
force-pushed
the
threadsafety
branch
from
2be833c to
877be4f
Compare
|
As discussed offline, added back the commits replacing |
CC @jpsamaroo