Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make offset an argument of overdub_pass! #168

Closed
wants to merge 2 commits into from
Closed

Make offset an argument of overdub_pass! #168

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a17e195
add offset argument to overdub_pass
MasonProtter Feb 18, 2020
6333009
Merge pull request #1 from MasonProtter/MasonProtter-offset
MasonProtter Feb 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/overdub.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@ const OVERDUB_ARGUMENTS_NAME = gensym("overdub_arguments")
# 4. If tagging is enabled, do the necessary IR transforms for the metadata tagging system
function overdub_pass!(reflection::Reflection,
context_type::DataType,
is_invoke::Bool = false)
is_invoke::Bool = false,
offset::Int=1)
signature = reflection.signature
method = reflection.method
static_params = reflection.static_params
Expand Down Expand Up @@ -175,7 +176,6 @@ function overdub_pass!(reflection::Reflection,
# destructure the generated argument slots into the overdubbed method's argument slots.
n_actual_args = fieldcount(signature)
n_method_args = Int(method.nargs)
offset = 1
for i in 1:n_method_args
if is_invoke && (i == 1 || i == 2)
# With an invoke call, we have: 1 is invoke, 2 is f, 3 is Tuple{}, 4... is args.
Expand Down