Improve type stability of Image constructor #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inference is run before the inlining pass, so when inference runs on constructors of the form `T{ndims(A)}(...)`, it does't see the inlined constant; it just sees an Int. The fix is to just use the type parameters directly. I've added this as an additional constructor to make sure it doesn't break any existing code with very poorly typed arrays.
|
Aha, I just noticed #370, which was reverted due to Windows failures. Looking at the AppVeyor logs there, it failed due to a missing method for the (Interesting that inference behaved differently on Windows in #370, though…) |
|
Hey, that's great! Interesting that neither the author of #370 nor myself thought of keeping the old one around as a backup. 👍 |
timholy
added a commit
that referenced
this pull request
Nov 3, 2015
Improve type stability of Image constructor
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inference is run before the inlining pass, so when inference runs on constructors of the form
T{ndims(A)}(...), it does't see the inlined constant; it just sees an Int. The fix is to just use the type parameters directly. I've added this as an additional constructor to make sure it doesn't break any existing code with very poorly typed arrays.