-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.14.0 Release Candidate #93
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
===========================================
+ Coverage 90.50% 100.00% +9.49%
===========================================
Files 16 17 +1
Lines 316 269 -47
===========================================
- Hits 286 269 -17
+ Misses 30 0 -30 ☔ View full report in Codecov by Sentry. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Thanks for the bugfix! I'm working out some issues with my local dev environment. Ever since we moved to TestItems I've been getting an opaque error message when trying to run tests from VS Code
It's probably just something to do with my Julia environment within Code, not particular to TestItems (I was previously running tests locally but directly from a terminal), but I've had to luck finding solutions online so far. |
Hm ok, I don't know about this error. Did you try to run the tests locally from a terminal via |
Looks like julia-vscode/julia-vscode#3633? |
Should we not have a |
Yes, indeed we should. Good point. I didn't realize that before, |
Wait...but we have? |
Ahh you mean, we should not have one? I think we should have one. So IMO it's fine as it is. |
I’m not sure what the “right” answer is, just noticed that the Issue you linked seemed to point to that as a proximate cause, and then I took a quick look around and noticed other major packages without a I’m on mobile right now, so not able to thoroughly research it and I don’t see any contra-indications anywhere about it. If it’s just a bug I can workaround by switching my default Julia to 1.11-rc |
Changes
-DEV
suffix from version numberjacobian(::BezierCurve, ts)
wheret
is outside domain[0,1]
should throw errorintegral(f, geometry)
whereparamdim(geometry)>3
is (currently) broken