Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.14.0 Release Candidate #93

Merged
merged 12 commits into from
Sep 29, 2024
Merged

v0.14.0 Release Candidate #93

merged 12 commits into from
Sep 29, 2024

Conversation

mikeingold
Copy link
Collaborator

@mikeingold mikeingold commented Sep 28, 2024

Changes

  • Removes -DEV suffix from version number
  • Adds tests to complete code coverage
    • jacobian(::BezierCurve, ts) where t is outside domain [0,1] should throw error
    • integral(f, geometry) where paramdim(geometry)>3 is (currently) broken
  • Change integrand function from Bézier test set to remove deprecation warnings.

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d784136) to head (3e74f57).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #93      +/-   ##
===========================================
+ Coverage   90.50%   100.00%   +9.49%     
===========================================
  Files          16        17       +1     
  Lines         316       269      -47     
===========================================
- Hits          286       269      -17     
+ Misses         30         0      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/combinations.jl Outdated Show resolved Hide resolved
mikeingold and others added 3 commits September 28, 2024 11:28
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
test/combinations.jl Outdated Show resolved Hide resolved
@mikeingold
Copy link
Collaborator Author

Thanks for the bugfix!

I'm working out some issues with my local dev environment. Ever since we moved to TestItems I've been getting an opaque error message when trying to run tests from VS Code

An error occurred attempting to run tests: Error: Pending response rejected since connection got disposed

It's probably just something to do with my Julia environment within Code, not particular to TestItems (I was previously running tests locally but directly from a terminal), but I've had to luck finding solutions online so far.

@JoshuaLampert
Copy link
Member

Hm ok, I don't know about this error. Did you try to run the tests locally from a terminal via ]test? If yes, does that work?

@JoshuaLampert
Copy link
Member

Looks like julia-vscode/julia-vscode#3633?

@mikeingold
Copy link
Collaborator Author

Looks like julia-vscode/julia-vscode#3633?

Should we not have a compat section in the test Project? I’m looking around other major projects and it looks like most only have deps specified.

@JoshuaLampert
Copy link
Member

Yes, indeed we should. Good point. I didn't realize that before,

@JoshuaLampert
Copy link
Member

Wait...but we have?

@JoshuaLampert
Copy link
Member

Ahh you mean, we should not have one? I think we should have one. So IMO it's fine as it is.

@mikeingold
Copy link
Collaborator Author

I’m not sure what the “right” answer is, just noticed that the Issue you linked seemed to point to that as a proximate cause, and then I took a quick look around and noticed other major packages without a [compat] section in their test/Project.toml.

I’m on mobile right now, so not able to thoroughly research it and I don’t see any contra-indications anywhere about it. If it’s just a bug I can workaround by switching my default Julia to 1.11-rc

@mikeingold mikeingold marked this pull request as ready for review September 29, 2024 01:33
@mikeingold mikeingold merged commit 4086902 into main Sep 29, 2024
15 checks passed
@mikeingold mikeingold deleted the v0.14-prep branch September 29, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants