-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links to reflect new JuliaGeometry ownership #117
Conversation
Deploying the preview of the documentation works and is also hosted at the correct URL, see https://juliageometry.github.io/MeshIntegrals.jl/previews/PR117/?pr=117. |
Looking at https://coveralls.io/github/JuliaGeometry/MeshIntegrals.jl seems like coveralls successfully recognizes the move, but https://app.codecov.io/gh/JuliaGeometry/MeshIntegrals.jl seems like codecov didn't. That something with codecov is still not working is also reflecting by the missing comment from the codecov bot in the PR. This indicates that it is still using the old url. But to investigate further we would need to look into the settings of the repo and check the CODECOV_TOKEN (maybe it changed after the move and needs to be updated with the new one?), however this is currently pending #115 (comment) |
We also need to remember to update the link to the docs in the about section of the repo, but I guess you can also not edit this one @mikeingold, right? |
Correct. That’s actually what made me realize I had lost owner rights, since I now don’t have access to the settings icon that I would’ve used to modify that link. |
Ok, let's wait for Julios response. |
@JoshuaLampert @mikeingold you should both have admin rights in MeshIntegrals.jl now. Please let me know if it is not the case. |
When I pull up my CodeCov profile I can still see the repo as if it's Once we get owner rights set up, it looks like we can just use this link to set it up again from scratch with a new token. |
Done. |
CodeCov token updated. |
I reran CI. Let's see what happens. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Looks like we are all set👍 |
After moving the repo to the JuliaGeometry org, the link for the documentation should be adjusted accordingly.
This is also a test PR to see whether CI, codecov and documentation deployment works.