This repository was archived by the owner on Nov 22, 2023. It is now read-only.
added ellipses #202
Open
added ellipses #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakir12
commented
Mar 26, 2020
| ellipse = Ellipse(Point2f0(0), Vec2f0(1)) | ||
| points = decompose(Point2f0, ellipse, 20) | ||
| @test length(points) == 20 | ||
| # TODO: currently, no ellipse meshes |
There was a problem hiding this comment.
@SimonDanisch I dunno how to implement src/primitives.jl#L28 for an Ellipse...
There was a problem hiding this comment.
You should be able to do the same thing, since the triangulation is the same either way.
There was a problem hiding this comment.
I tried adding
function (::Type{T})(c::Ellipse, n = 32) where T <: AbstractMeshto primitives.jl but I don't understand why it isn't working. Honestly, my understanding here is really low, I'm basically copy pasting things that were implemented specifically for HyperSphere and adjusting them to an ellipse (so 2 radii, not one). Stumped, do you know what's missing?
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.