-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use contextual dispatch for device functions. #750
Conversation
708a1b4
to
ea8c0dd
Compare
ea8c0dd
to
322d8c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #750 +/- ##
==========================================
- Coverage 78.25% 78.21% -0.04%
==========================================
Files 122 121 -1
Lines 7269 7211 -58
==========================================
- Hits 5688 5640 -48
+ Misses 1581 1571 -10
Continue to review full report at Codecov.
|
This seems to work at a first glance:
after adding |
21c0848
to
fa18f3d
Compare
fa18f3d
to
bcf1b82
Compare
@vchuravy I didn't include your suggestions; |
ea52da1
to
90b9366
Compare
Can you add an warning to that effect? E.g. that
Yeah no plans here to call |
If you want to rely on this being available externally, we could try and make that a possibility. Maybe with a convenient |
Builds on JuliaGPU/GPUCompiler.jl#151, requires JuliaLang/julia#39697 on Julia 1.7 but should also work on 1.6. Supersedes JuliaGPU/CUDAnative.jl#334.
Fixes #60
Fixes #42
Fixes #659
Fixes #140:
Fixes #76:
Fixes #71:
Fixes #171:
Should fix #169, but I can't reproduce the original issue.
Should fix #130.