Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_time
->is_temporal
: b/c the package is called SpatioTemporalTraitsaxes
andkeys
for public functions. This comment worked on me for a while. The goal is to have sensible defaults that may be overloaded elsewhere. So it won't always make sense to havespatial_keys
, butspatial_indices
will make sense whether working with an array, plot, or mesh.onset
is nowtime_first
andtime_end
was changed totime_last
for symmetry. Alsospatial_offset
is nowspatial_first
. The short of the conversation is that the onset and offset are terms that may be interpreted differently depending on whether the first time point/spatial index coincide with the exact location of corresponding values or are off center from it as a reference.