Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and get basic tests runnning #3

Merged
merged 3 commits into from
Sep 4, 2021
Merged

Update and get basic tests runnning #3

merged 3 commits into from
Sep 4, 2021

Conversation

Tokazama
Copy link
Member

@Tokazama Tokazama commented Sep 4, 2021

  • is_time -> is_temporal: b/c the package is called SpatioTemporalTraits
  • Removed direct reference to axes and keys for public functions. This comment worked on me for a while. The goal is to have sensible defaults that may be overloaded elsewhere. So it won't always make sense to have spatial_keys, but spatial_indices will make sense whether working with an array, plot, or mesh.
  • All things should be inferable now.
  • Given the conversation in Interop/testing #2, onset is now time_first and time_end was changed to time_last for symmetry. Also spatial_offset is now spatial_first. The short of the conversation is that the onset and offset are terms that may be interpreted differently depending on whether the first time point/spatial index coincide with the exact location of corresponding values or are off center from it as a reference.
  • A very minimal set of metadata options are thrown in there right now. Mostly as a starting point and not a final design decision.

@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@938edb4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   60.78%           
=========================================
  Files             ?        2           
  Lines             ?      102           
  Branches          ?        0           
=========================================
  Hits              ?       62           
  Misses            ?       40           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938edb4...c3dacc9. Read the comment docs.

@Tokazama Tokazama merged commit ddf44a8 into master Sep 4, 2021
@Tokazama Tokazama deleted the bike-shed branch September 4, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant