Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing healthcheck function due to platform inconsistency #35

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Removing healthcheck function due to platform inconsistency #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bccec6
Removing healthcheck function due to platform inconsistency
pebeto Feb 14, 2024
5755fe8
Bump 0.4.0
pebeto Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "MLJFlow"
uuid = "7b7b8358-b45c-48ea-a8ef-7ca328ad328f"
authors = ["Jose Esparza <[email protected]>"]
version = "0.3.0"
version = "0.4.0"

[deps]
MLFlowClient = "64a0f543-368b-4a9a-827a-e71edb2a0b83"
Expand Down
4 changes: 2 additions & 2 deletions src/MLJFlow.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ module MLJFlow
using MLJBase: Model, Machine, name
using MLJModelInterface: flat_params
using MLFlowClient: MLFlow, logparam, logmetric,
createrun, MLFlowRun, updaterun,
healthcheck, logartifact, getorcreateexperiment
createrun, MLFlowRun, updaterun, logartifact,
getorcreateexperiment

import Base: show
import MLJBase: save, log_evaluation
Expand Down
6 changes: 1 addition & 5 deletions src/types.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@ function Logger(baseuri; experiment_name="MLJ experiment",
artifact_location=nothing, verbosity=1)
service = MLFlow(baseuri)

if ~healthcheck(service)
error("It seems that the MLFlow server is not running at specified "*
"location, $baseuri. For more information, see https://mlflow.org/docs/latest/quickstart.html")
end
Logger(service, verbosity, experiment_name, artifact_location)
end
function show(io::IO, logger::MLJFlow.Logger)
Expand All @@ -46,4 +42,4 @@ function show(io::IO, logger::MLJFlow.Logger)
" artifact_location=\"$(logger.artifact_location)\",\n" *
") using MLFlow API version $(logger.service.apiversion)"
)
end
end
Loading