Changing MLFLOW_URI to MLFLOW_TRACKING_URI, and baseuri to `api…

…root`
JuliaAI · May 17, 2024 · e205bcc · e205bcc
1 parent 9b81887
commit e205bcc
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/src/types.jl b/src/types.jl
@@ -1,5 +1,5 @@
 """
-    Logger(baseuri; experiment_name="MLJ experiment",
+    Logger(apiroot; experiment_name="MLJ experiment",
         artifact_location=nothing)
 
 A wrapper around a MLFlow service, with an experiment name and an artifact
@@ -9,8 +9,8 @@ multiple methods in MLJBase.
 To use this logger, you need to have a MLFlow server running. For more
 information, see [MLFlow documentation](https://www.mlflow.org/docs/latest/quickstart.html).
 
-Depending on the MLFlow server configuration, the `baseuri` can be a local
-server or a remote server. The `experiment_name` is used to identify the
+Depending on the MLFlow server configuration, the `apiroot` can be a local
+or a remote server API. The `experiment_name` is used to identify the
 experiment in the MLFlow server. If the experiment does not exist, it will be
 created with the default name "MLJ experiment". The `artifact_location` is
 used to store the artifacts of the experiment. If not provided, a default
@@ -29,15 +29,15 @@ struct Logger
     experiment_name::String
     artifact_location::Union{String,Nothing}
 end
-function Logger(baseuri; experiment_name="MLJ experiment",
+function Logger(apiroot; experiment_name="MLJ experiment",
     artifact_location=nothing, verbosity=1)
-    service = MLFlow(baseuri)
+    service = MLFlow(apiroot)
 
     Logger(service, verbosity, experiment_name, artifact_location)
 end
 function show(io::IO, logger::MLJFlow.Logger)
     print(io,
-        "MLFLowLogger(\"$(logger.service.baseuri)\",\n" *
+        "MLFLowLogger(\"$(logger.service.apiroot)\",\n" *
         "   experiment_name=\"$(logger.experiment_name)\",\n" *
         "   artifact_location=\"$(logger.artifact_location)\",\n" *
         ") using MLFlow API version $(logger.service.apiversion)"

diff --git a/test/base.jl b/test/base.jl
@@ -1,5 +1,5 @@
 @testset verbose = true "base" begin
-    logger = MLJFlow.Logger(ENV["MLFLOW_URI"];
+    logger = MLJFlow.Logger(ENV["MLFLOW_TRACKING_URI"];
         experiment_name="MLJFlow tests",
         artifact_location="/tmp/mlj-test")
 

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -11,11 +11,11 @@ using StatisticalMeasures
 # To run this tests, you need to set the URI of your MLFlow server. By default,
 # you can set:
 #
-# ENV["MLFLOW_URI"] = "http://localhost:5000"
+# ENV["MLFLOW_TRACKING_URI"] = "http://localhost:5000/api"
 #
 # For more information, see https://mlflow.org/docs/latest/quickstart.html#view-mlflow-runs-and-experiments
-if ~haskey(ENV, "MLFLOW_URI")
-    error("WARNING: MLFLOW_URI is not set. To run this tests, you need to set the URI of your MLFlow server")
+if ~haskey(ENV, "MLFLOW_TRACKING_URI")
+    error("WARNING: MLFLOW_TRACKING_URI is not set. To run this tests, you need to set the URI of your MLFlow server API")
 end
 
 include("base.jl")

diff --git a/test/types.jl b/test/types.jl
@@ -1,12 +1,12 @@
 @testset "types" begin
-    logger = MLJFlow.Logger(ENV["MLFLOW_URI"])
+    logger = MLJFlow.Logger(ENV["MLFLOW_TRACKING_URI"])
 
     @test typeof(logger) == MLJFlow.Logger
     @test typeof(logger.service) == MLFlow
 
     io = IOBuffer()
     show(io, logger)
-    test_string = "MLFLowLogger(\"$(logger.service.baseuri)\",\n" *
+    test_string = "MLFLowLogger(\"$(logger.service.apiroot)\",\n" *
         "   experiment_name=\"$(logger.experiment_name)\",\n" *
         "   artifact_location=\"$(logger.artifact_location)\",\n" *
         ") using MLFlow API version $(logger.service.apiversion)"