Code

Segfault fix#30

Code

Merged

miguelbiron merged 65 commits intomainJulia-Tempering/Pigeons.jl:mainfrom investigate-segfaultJulia-Tempering/Pigeons.jl:investigate-segfaultCopy head branch name to clipboardMar 13, 2023

+400-113

Commits

Commits on Mar 6, 2023

• Keeping only the suspected faulty test (by commenting out rest (!))

  alexandrebouchard

  committed
  23b59d3

  Copy full SHA for 23b59d3

• Removing Turing from test to isolate only one error at the time

  alexandrebouchard

  committed
  40001d0

  Copy full SHA for 40001d0

• Check behaviour on different threadlevels

  alexandrebouchard

  committed
  ff5aac9

  Copy full SHA for ff5aac9

• Back to same threadlevel as not changing crashing behaviour

  alexandrebouchard

  committed
  d00ff53

  Copy full SHA for d00ff53

• More conservative tag ub?

  alexandrebouchard

  committed
  69bb270

  Copy full SHA for 69bb270

• Revert "More conservative tag ub?"

  Show description for d94252f
  alexandrebouchard

  committed
  d94252f

  Copy full SHA for d94252f

• Trying on OpenMPI instead of mpich

  alexandrebouchard

  committed
  bcf016d

  Copy full SHA for bcf016d

Commits on Mar 7, 2023

• Going back to mpich, trying threadlevel = :multiple

  alexandrebouchard

  committed
  379df4b

  Copy full SHA for 379df4b

• Back to funneled as :multiple still crashes

  alexandrebouchard

  committed
  2cd3571

  Copy full SHA for 2cd3571

• Further simplification

  alexandrebouchard

  committed
  c8a0261

  Copy full SHA for c8a0261

Commits on Mar 8, 2023

• Candidate fix

  alexandrebouchard

  committed
  6217650

  Copy full SHA for 6217650

• Reintroducing other tests

  alexandrebouchard

  committed
  1f16936

  Copy full SHA for 1f16936

• purge tests from Turing, use only DynamicPPL

  miguelbiron

  committed
  0ca198f

  Copy full SHA for 0ca198f

• Another free

  alexandrebouchard

  committed
  ee276fc

  Copy full SHA for ee276fc

• Trying to run tests with more rounds

  alexandrebouchard

  committed
  491c26b

  Copy full SHA for 491c26b

Commits on Mar 9, 2023

• system MPI test

  miguelbiron

  committed
  fab7934

  Copy full SHA for fab7934

• fix typos

  miguelbiron

  committed
  2ed0aae

  Copy full SHA for 2ed0aae

• remove step that does not make sense outside MPI.jl

  miguelbiron

  committed
  c271261

  Copy full SHA for c271261

• setup MPIPreferences in the test env

  miguelbiron

  committed
  e3f569a

  Copy full SHA for e3f569a

• possible fix to Pkg missing

  miguelbiron

  committed
  77824ea

  Copy full SHA for 77824ea

• possible fix to Pkg missing

  miguelbiron

  committed
  c69b76a

  Copy full SHA for c69b76a

• add missing env

  miguelbiron

  committed
  523f9c1

  Copy full SHA for 523f9c1

• another try

  miguelbiron

  committed
  949b628

  Copy full SHA for 949b628

• test now has its own Project.toml

  miguelbiron

  committed
  895a45f

  Copy full SHA for 895a45f

• force Pkg.instantiate in ChildProcess

  miguelbiron

  committed
  13c9cd2

  Copy full SHA for 13c9cd2

• dont use --project in ChildProcess

  miguelbiron

  committed
  1772d82

  Copy full SHA for 1772d82

• ChildProcess inherits the exact same active project

  miguelbiron

  committed
  bdf71ce

  Copy full SHA for bdf71ce

• new approach

  miguelbiron

  committed
  2bcd825

  Copy full SHA for 2bcd825

• Changing approach for Isend/isend: explicit Waitall for all requests

  Show description for eadbfcd
  alexandrebouchard

  committed
  eadbfcd

  Copy full SHA for eadbfcd

• Is this a Turing multi-threading issue?

  alexandrebouchard

  committed
  57d0921

  Copy full SHA for 57d0921

• Testing single-thread for all

  Show description for 63aad97
  alexandrebouchard

  committed
  63aad97

  Copy full SHA for 63aad97

• Adding a temporary "dry run" to see if problem cause by some compilation

  alexandrebouchard

  committed
  7a8de7e

  Copy full SHA for 7a8de7e

• Commenting out Turing and Blang, to see behaviour on toy_mvn and swap(0.5)

  alexandrebouchard

  committed
  5812127

  Copy full SHA for 5812127

• openmpi_jll test

  miguelbiron

  committed
  270333f

  Copy full SHA for 270333f

• openmpi_jll test

  miguelbiron

  committed
  2b49008

  Copy full SHA for 2b49008

• openmpi_jll test

  miguelbiron

  committed
  9c6497f

  Copy full SHA for 9c6497f

• openmpi_jll test

  miguelbiron

  committed
  d68dc6c

  Copy full SHA for d68dc6c

• more messages from Child processes

  miguelbiron

  committed
  38de7cf

  Copy full SHA for 38de7cf

• extra arg to OpenMPI

  miguelbiron

  committed
  8537307

  Copy full SHA for 8537307

• rm mpi version query

  miguelbiron

  committed
  c2b732b

  Copy full SHA for c2b732b

• use old julia_cmd + rm manifest as in MPI.jl CI

  miguelbiron

  committed
  0e82a84

  Copy full SHA for 0e82a84

• add --oversubscribe for OpenMPI + rethrow exception

  miguelbiron

  committed
  82a4210

  Copy full SHA for 82a4210

• simplify logging

  miguelbiron

  committed
  700c712

  Copy full SHA for 700c712

• force instantiate + precompile

  miguelbiron

  committed
  ebcb3a6

  Copy full SHA for ebcb3a6

Commits on Mar 10, 2023

• Add mpi_args to mpi_test

  alexandrebouchard

  committed
  ad69b34

  Copy full SHA for ad69b34

• Temporary: trying to speed up some key tests

  alexandrebouchard

  committed
  6bde8fe

  Copy full SHA for 6bde8fe

• Fix

  alexandrebouchard

  committed
  7b5e7d4

  Copy full SHA for 7b5e7d4

• Fix the fix + reintroducing the system-MPI tests

  alexandrebouchard

  committed
  fc34b85

  Copy full SHA for fc34b85

• Add back libmpich-dev to resume investigation on ghostbug

  alexandrebouchard

  committed
  5ba839e

  Copy full SHA for 5ba839e

• Trying to simplify CI setup needed to reproduce ghostbug

  alexandrebouchard

  committed
  2b37c0f

  Copy full SHA for 2b37c0f

• Fix last commit

  alexandrebouchard

  committed
  0847901

  Copy full SHA for 0847901

• toy_mvn not enough to manifest ghostbug, trying Turing

  alexandrebouchard

  committed
  f75a280

  Copy full SHA for f75a280

• test mpich+openmpi using brew

  miguelbiron

  committed
  93033fc

  Copy full SHA for 93033fc

• fix wrong abi detection for mpich

  miguelbiron

  committed
  d46d429

  Copy full SHA for d46d429

• move xtra args to MPI struct + remove prints + failsafe for empty current project

  miguelbiron

  committed
  7a11074

  Copy full SHA for 7a11074

• mpiexec args for childprocess

  miguelbiron

  committed
  d89911a

  Copy full SHA for d89911a

Commits on Mar 11, 2023

• re-introduce all CI tests + fix bug in building mpi cmd

  miguelbiron

  committed
  aa233e8

  Copy full SHA for aa233e8

• add support for using without Project.toml

  miguelbiron

  committed
  42993fd

  Copy full SHA for 42993fd

• add comment explaining why we wait on Isend

  miguelbiron

  committed
  42bdd75

  Copy full SHA for 42bdd75

• mpiexec_args is a Cmd now

  miguelbiron

  committed
  c5cb70a

  Copy full SHA for c5cb70a

• re-instate all tests

  miguelbiron

  committed
  9e31b49

  Copy full SHA for 9e31b49

• Test hypothesis that GC+multithread is issue; determine all MPIs affects

  alexandrebouchard

  committed
  74a4355

  Copy full SHA for 74a4355

• force instantiate in mpi_test + add MicrosoftMPI test

  miguelbiron

  committed
  7454ae9

  Copy full SHA for 7454ae9

Commits on Mar 12, 2023

• adding back all test

  miguelbiron

  committed
  18ef655

  Copy full SHA for 18ef655

Commits on Mar 13, 2023

• Change mpi_active impl to fix open mpi bug

  Show description for b9c34d9
  alexandrebouchard

  committed
  b9c34d9

  Copy full SHA for b9c34d9